{{ message }}
gh-127146: Update test skips for Emscripten 4.0.2 - #129474
Merged
Merged
Conversation
freakboy3742
requested changes
Jan 30, 2025
freakboy3742
left a comment
freakboy3742
left a comment
Contributor
There was a problem hiding this comment.
Looks fairly straightforward; a couple of small suggestions/questions inline.
Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Contributor
Author
|
Okay I applied the suggestions. |
freakboy3742
approved these changes
Mar 16, 2025
freakboy3742
left a comment
freakboy3742
left a comment
Contributor
There was a problem hiding this comment.
Looks like you missed one (the continue/return change) - but with that merged, looks like everything is working as expected.
|
Contributor
|
I can't see any reason why this test failure would have been caused by this PR. |
Contributor
Author
plashchynski
pushed a commit
to plashchynski/cpython
that referenced
this pull request
Mar 17, 2025
Updates test skips to reflect capabilities of Emscripten 4.0.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emscripten 4.0.2 brought in a few new file system bug fixes.