{{ message }}
bpo-29643: Fix check for --enable-optimizations - #129
Merged
Merged
Conversation
The presence of the --enable-optimizations flag is indicated by the value of $enableval, but the configure script was checking $withval, resulting in the --enable-optimizations flag being effectively ignored.
Contributor
Author
|
I have signed the CLA.
… On Feb 16, 2017, at 12:57 AM, the-knights-who-say-ni ***@***.***> wrote:
Hello, and thanks for your contribution!
I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement <https://www.python.org/psf/contrib/contrib-form/> (CLA).
Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org <http://bugs.python.org/> (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:
If you don't have an account on b.p.o, please create one ***@***.***=register>
Make sure your GitHub username is listed in "Your Details" at b.p.o <https://cloud.githubusercontent.com/assets/2680980/22867185/d3aedcf8-f137-11e6-8469-d5f7861a1073.png>
If you have not already done so, please sign the PSF contributor agreement <https://www.python.org/psf/contrib/contrib-form/>
If you just signed the CLA, please wait at least one US business day and then check "Your Details" on bugs.python.org <https://bugs.python.org/> to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
Reply here saying you have completed the above steps
Thanks again to your contribution and we look forward to looking at it!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#129 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAilLLVQvNG2dm0Gp9C0pmXkbZW2LudLks5rc-VFgaJpZM4MCnaf>.
|
Member
|
It would be nice to open an issue on http://bugs.python.org/ to track this problem. And don't forget to nosy @brettcannon . |
Member
|
My Makefile knowledge is fairly limited so I'm adding @gpshead to see if he is up for reviewing. If not then I can handle it. And can you open an issue on bugs.python.org for this, @aw1621107 ? |
Contributor
Author
|
Oops, forgot about that. Submitted issue 29643. Sorry about the delay. |
brettcannon
changed the title
Member
|
thanks, this change looks good. |
Member
|
When checking it in, we need to check in regenerated configure files along with it. but that could make easy backporting/merging a pain. do we have a process preference for configure.ac & configure changes? or just leave it up to whomever is merging? |
Member
|
@gpshead I think we have a version requirement specified in configure.ac, but otherwise the committer just runs autoconf and commits both configure.ac and configure. |
Member
|
I'm sorry. I failed to merge master and I used |
Member
|
When I ran autoreconf, unrelated changes (pkg-config 0.29 -> 0.29.2) happens. |
Member
methane
referenced
this pull request
in methane/cpython
Mar 28, 2017
The presence of the ``--enable-optimizations`` flag is indicated by the value of ``$enableval``, but the configure script was checking ``$withval``, resulting in the ``--enable-optimizations`` flag being effectively ignored. (cherry picked from commit 8cea592)
vstinner
pushed a commit
that referenced
this pull request
Mar 28, 2017
The presence of the ``--enable-optimizations`` flag is indicated by the value of ``$enableval``, but the configure script was checking ``$withval``, resulting in the ``--enable-optimizations`` flag being effectively ignored. (cherry picked from commit 8cea592)
methane
referenced
this pull request
in methane/cpython
Mar 28, 2017
The presence of the ``--enable-optimizations`` flag is indicated by the value of ``$enableval``, but the configure script was checking ``$withval``, resulting in the ``--enable-optimizations`` flag being effectively ignored. (cherry picked from commit 8cea592)
This was referenced Mar 28, 2017
akruis
referenced
this pull request
in stackless-dev/stackless
Sep 5, 2017
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Sep 9, 2017
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Sep 9, 2017
Re-add the test for NULL. It got lost in change 20dad21ded9c (2.7-slp) and dae0e80f141d (3.2-slp). Update the documentation. https://bitbucket.org/stackless-dev/stackless/issues/129 (grafted from a4dfdadc7cf547e7f589e8191b8bab2c67e34f00)
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Oct 10, 2017
pablogsal
referenced
this pull request
in pablogsal/cpython
Aug 13, 2022
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
lazka
added a commit
to lazka/cpython
that referenced
this pull request
Mar 2, 2023
missing ref on the return value Fixes python#129
lazka
added a commit
to lazka/cpython
that referenced
this pull request
Apr 7, 2023
missing ref on the return value Fixes python#129
This was referenced Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The presence of the --enable-optimizations flag is indicated by the
value of $enableval, but the configure script was checking $withval,
resulting in the --enable-optimizations flag being effectively ignored.