{{ message }}
gh-128002: use _PyObject_SetMaybeWeakref when creating tasks in asyncio - #128885
Merged
Merged
Conversation
kumaraditya303
requested review from
1st1,
asvetlov and
willingc
as code owners
January 15, 2025 15:32
9 tasks
Contributor
Contributor
Author
|
I think the following code appears to catch that bug: import asyncio
import threading
def func():
loop = asyncio.EventLoop()
async def coro():
await asyncio.sleep(0.01)
lock = threading.Lock()
count = 0
async def main():
nonlocal count
while True:
with lock:
asyncio.create_task(coro())
count = len(asyncio.all_tasks(loop))
th = threading.Thread(target=loop.run_until_complete, args=(main(),))
th.start()
def check():
with lock:
assert count == len(asyncio.all_tasks(loop))
threads = [threading.Thread(target=check) for _ in range(10)]
for t in threads:
t.start()
for t in threads:
t.join()
func()Without the fix, I see many assertion errors and with it there isn't any. |
Contributor
Author
|
@colesbury Added test based on the above code. |
colesbury
approved these changes
Jan 23, 2025
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.