{{ message }}
gh-97850: Remove the mention of removal from ResourceReader docs - #128602
Merged
Merged
Conversation
tomasr8
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
January 7, 2025 23:29
31 tasks
tomasr8
added
needs backport to 3.12
Member
Member
Author
Yes, I missed that one. I'll update the PR in a bit! |
Member
Member
Author
|
Oh wait, that is the other Sorry for the confusion @StanFromIreland, I should've checked better :/ but thanks for the help! |
brettcannon
removed their request for review
January 8, 2025 21:00
jaraco
approved these changes
Jan 8, 2025
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 8, 2025
…ocs (pythonGH-128602) Remove the mention of removal from ResourceReader docs (cherry picked from commit a1284e9) Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 8, 2025
…ocs (pythonGH-128602) Remove the mention of removal from ResourceReader docs (cherry picked from commit a1284e9) Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
|
GH-128654 is a backport of this pull request to the 3.13 branch. |
|
GH-128655 is a backport of this pull request to the 3.12 branch. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently no plan to remove
ResourceReader, especially given that the suggested alternativeTraversableResourcesinherits fromResourceReader. Let's remove the mention of a removal for now.Related discussion: #97850 (comment)
📚 Documentation preview 📚: https://cpython-previews--128602.org.readthedocs.build/