gh-126703: Add freelist for PyMethodObject by eendebakpt · Pull Request #128594 · python/cpython · GitHub
Skip to content

gh-126703: Add freelist for PyMethodObject #128594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 2 commits into from
Jan 12, 2025
+12 −3
Merged

gh-126703: Add freelist for PyMethodObject #128594

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
512efff
Add freelist for PyMethodObject
eendebakpt Jan 7, 2025
be92a6e
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add freelist for PyMethodObject
  • Loading branch information
@eendebakpt
eendebakpt committed Jan 7, 2025
commit 512efff0dff4c1de5ce4b1eae75f3dffadfd7c93
2 changes: 2 additions & 0 deletions Include/internal/pycore_freelist_state.h
View file
Open in desktop
11 changes: 8 additions & 3 deletions Objects/classobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#include "Python.h"
#include "pycore_call.h" // _PyObject_VectorcallTstate()
#include "pycore_ceval.h" // _PyEval_GetBuiltin()
#include "pycore_freelist.h"
#include "pycore_object.h"
#include "pycore_pyerrors.h"
#include "pycore_pystate.h" // _PyThreadState_GET()
Expand Down Expand Up @@ -112,9 +113,12 @@ PyMethod_New(PyObject *func, PyObject *self)
PyErr_BadInternalCall();
return NULL;
}
PyMethodObject *im = PyObject_GC_New(PyMethodObject, &PyMethod_Type);
PyMethodObject *im = _Py_FREELIST_POP(PyMethodObject, pymethodobjects);
if (im == NULL) {
return NULL;
im = PyObject_GC_New(PyMethodObject, &PyMethod_Type);
if (im == NULL) {
return NULL;
}
}
im->im_weakreflist = NULL;
im->im_func = Py_NewRef(func);
Expand Down Expand Up @@ -245,7 +249,8 @@ method_dealloc(PyObject *self)
PyObject_ClearWeakRefs((PyObject *)im);
Py_DECREF(im->im_func);
Py_XDECREF(im->im_self);
PyObject_GC_Del(im);
assert(Py_IS_TYPE(self, &PyMethod_Type));
_Py_FREELIST_FREE(pymethodobjects, (PyObject *)im, PyObject_GC_Del);
}

static PyObject *
Expand Down
1 change: 1 addition & 0 deletions Objects/object.c
View file
Open in desktop