{{ message }}
gh-128481: Add missing documentation for traceback.FrameSummary - #128484
Merged
Conversation
ZeroIntensity
added
needs backport to 3.13
picnixz
previously requested changes
Jan 4, 2025
Contributor
Author
Member
No, I meant it cannot have a default value without |
Contributor
Author
|
Understood, I have fixed it with latest commit. |
picnixz
reviewed
Jan 11, 2025
picnixz
reviewed
Mar 1, 2025
picnixz
reviewed
Mar 1, 2025
picnixz
reviewed
Mar 1, 2025
picnixz
approved these changes
Mar 1, 2025
picnixz
reviewed
Mar 1, 2025
picnixz
approved these changes
Mar 1, 2025
Member
|
Do you want a final look @ZeroIntensity before I merge it? |
Contributor
Author
|
Of course. |
picnixz
changed the title
traceback.FrameSummary.end_{col,line}traceback.FrameSummary.end_{col,line}no
picnixz
changed the title
traceback.FrameSummary.end_{col,line}notraceback.FrameSummary
|
Thanks @Damien-Chen for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Member
|
Thank you! |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 2, 2025
…ythonGH-128484) Complete the `traceback.FrameSummary` signature and add missing documentation for the `colno` and `end_{col,line}no` attributes. (cherry picked from commit 051f0e5) Co-authored-by: Damien <81557462+Damien-Chen@users.noreply.github.com>
|
GH-130753 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 2, 2025
…ythonGH-128484) Complete the `traceback.FrameSummary` signature and add missing documentation for the `colno` and `end_{col,line}no` attributes. (cherry picked from commit 051f0e5) Co-authored-by: Damien <81557462+Damien-Chen@users.noreply.github.com>
picnixz
pushed a commit
that referenced
this pull request
Mar 2, 2025
…H-128484) (#130753) * gh-128481: Improve documentation for `traceback.FrameSummary` (GH-128484) Complete the `traceback.FrameSummary` signature and add missing documentation for the `colno` and `end_{col,line}no` attributes. (cherry picked from commit 051f0e5) Co-authored-by: Damien <81557462+Damien-Chen@users.noreply.github.com>
picnixz
pushed a commit
that referenced
this pull request
Mar 2, 2025
…H-128484) (#130754) * gh-128481: Improve documentation for `traceback.FrameSummary` (GH-128484) Complete the `traceback.FrameSummary` signature and add missing documentation for the `colno` and `end_{col,line}no` attributes. (cherry picked from commit 051f0e5) Co-authored-by: Damien <81557462+Damien-Chen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to #128481, add missing documentation for
end_lineno,colnoandend_colno.traceback.FrameSummary.end_{col,line}noattributes #128481📚 Documentation preview 📚: https://cpython-previews--128484.org.readthedocs.build/en/128484/library/traceback.html#traceback.FrameSummary