gh-128277: use relaxed atomics for `sock_fd` by kumaraditya303 · Pull Request #128304 · python/cpython · GitHub
Skip to content

gh-128277: use relaxed atomics for sock_fd - #128304

Merged
kumaraditya303 merged 1 commit into
python:mainfrom
kumaraditya303:sock_fd
Dec 31, 2024
Merged

kumaraditya303 merged 1 commit into
python:mainfrom
kumaraditya303:sock_fd

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Dec 28, 2024

Copy link
Copy Markdown
Contributor

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after the brief look

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's worth doing these sorts of changes for file descriptors. We still have unfixable race conditions when sockets are closed concurrently (see #121544)

@colesbury

Copy link
Copy Markdown
Contributor

@kumaraditya303
kumaraditya303 merged commit 7c72c1f into python:main Dec 31, 2024
@kumaraditya303
kumaraditya303 deleted the sock_fd branch December 31, 2024 06:20
@kumaraditya303

Copy link
Copy Markdown
Contributor Author

I'm not sure it's worth doing these sorts of changes for file descriptors. We still have unfixable race conditions when sockets are closed concurrently (see #121544)

I see, I did this just for asyncio because tsan was complaining while running the existing test suite and this fixes all of this AFAICS. If we aren't planning to fix this maybe we should add some tsan suppressions for these for the time being?

@bedevere-bot

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants