gh-111178: fix UBSan failures in `Modules/{blake2,md5,sha1,sha2,sha3}module.c` by picnixz · Pull Request #128248 · python/cpython · GitHub
Skip to content

gh-111178: fix UBSan failures in Modules/{blake2,md5,sha1,sha2,sha3}module.c - #128248

Merged
encukou merged 14 commits into
python:mainfrom
picnixz:fix/ubsan/sha-111178
Jan 27, 2025
Merged

gh-111178: fix UBSan failures in Modules/{blake2,md5,sha1,sha2,sha3}module.c#128248
encukou merged 14 commits into
python:mainfrom
picnixz:fix/ubsan/sha-111178

Conversation

@picnixz

@picnixz picnixz commented Dec 25, 2024

Copy link
Copy Markdown
Member

Effective commits

  • fix UBSan failures in blake2module.c
  • fix UBSan failures in md5module.c
  • fix UBSan failures in sha1module.c
  • fix UBSan failures in sha2module.c
  • fix UBSan failures in sha3module.c

Cosmetics

  • suppress unused return values
  • remove redundant casts in constructors
  • suppress unused parameters in {md5,sha*,blake2}module.c

@picnixz picnixz changed the title gh-111178: fix UBSan failures in Modules/{sha1,sha2,sh3,md5}module.c gh-111178: fix UBSan failures in Modules/{blake2,md5,sha1,sha2,sha3}module.c Dec 25, 2024
@encukou
encukou merged commit 922cfec into python:main Jan 27, 2025
@encukou

encukou commented Jan 27, 2025

Copy link
Copy Markdown
Member

@picnixz
picnixz deleted the fix/ubsan/sha-111178 branch February 2, 2025 21:52
@picnixz

picnixz commented Feb 2, 2025

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants