bpo-20180: Use argument clinic for dict.pop() and dict.popitem() by methane · Pull Request #12792 · python/cpython · GitHub
Skip to content

bpo-20180: Use argument clinic for dict.pop() and dict.popitem() - #12792

Merged
methane merged 5 commits into
python:masterfrom
methane:dict-clinic
Apr 12, 2019
Merged

bpo-20180: Use argument clinic for dict.pop() and dict.popitem()#12792
methane merged 5 commits into
python:masterfrom
methane:dict-clinic

Conversation

@methane

@methane methane commented Apr 12, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@tirkarthi

tirkarthi commented Apr 12, 2019

Copy link
Copy Markdown
Member

@methane

methane commented Apr 12, 2019 via email

Copy link
Copy Markdown
Member Author

@tirkarthi

tirkarthi commented Apr 12, 2019

Copy link
Copy Markdown
Member

Is it worth adding a NEWS entry for such speedups since this is a considerable one reducing 120ns to 80ns.

@methane

methane commented Apr 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

I am not sure about it.

Some methods changed from METH_VARARGS to METH_FASTCALL without NEWS entry.
For example, #9560, #9164.

@methane methane changed the title clinic: dict.pop() and dict.popitem() bpo-20180: Use argument clinic for dict.pop() and dict.popitem() Apr 12, 2019
@tirkarthi

tirkarthi commented Apr 12, 2019

Copy link
Copy Markdown
Member

@methane
methane merged commit 9e4f2f3 into python:master Apr 12, 2019
@methane
methane deleted the dict-clinic branch April 12, 2019 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@methane @tirkarthi @the-knights-who-say-ni @bedevere-bot