{{ message }}
Free arena on _PyCompile_AstOptimize failure in Py_CompileStringObject#127910
Merged
berkerpeksag merged 1 commit intoDec 16, 2024
Merged
Conversation
Eclips4
approved these changes
Dec 14, 2024
Member
Member
Author
|
I saw the snippet of |
Member
Author
|
I took some time to think about how to write a test. If this were a refleak, I would probably launch a Python process with Also, it seems that the only way to trigger this issue is by testing |
iritkatriel
approved these changes
Dec 15, 2024
|
Thanks @berkerpeksag for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 16, 2024
pythonGH-127910) After commit 10a91d7 introduced arena cleanup, commit 2dfbd4f removed the free call when _PyCompile_AstOptimize fails. (cherry picked from commit cfeaa99) Co-authored-by: Berker Peksag <berker.peksag@gmail.com>
berkerpeksag
added a commit
that referenced
this pull request
Dec 16, 2024
…ngObject (GH-128006) Free arena on _PyCompile_AstOptimize failure in Py_CompileStringObject (GH-127910) After commit 10a91d7 introduced arena cleanup, commit 2dfbd4f removed the free call when _PyCompile_AstOptimize fails. (cherry picked from commit cfeaa99) Co-authored-by: Berker Peksag <berker.peksag@gmail.com>
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
pythonGH-127910) After commit 10a91d7 introduced arena cleanup, commit 2dfbd4f removed the free call when _PyCompile_AstOptimize fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After commit 10a91d7 introduced arena cleanup, commit 2dfbd4f removed the free call when _PyCompile_AstOptimize fails.