[3.12] gh-126499: test_ssl: Don't assume err.reason is a string (GH-126501) by miss-islington · Pull Request #126573 · python/cpython · GitHub
Skip to content

[3.12] gh-126499: test_ssl: Don't assume err.reason is a string (GH-126501) #126573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 1 commit into from
Nov 11, 2024
+1 −1
Merged

[3.12] gh-126499: test_ssl: Don't assume err.reason is a string (GH-126501) #126573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-126499: test_ssl: Don't assume err.reason is a string (GH-126501) 
The skipping machinery called `getattr(err, "reason", "")` on an arbitrary
exception. As intermittent Buildbot failures show, sometimes it's set
to None.

Convert it to string for this specific check.
(cherry picked from commit 78ad7e6)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
  • Loading branch information
@encukou @miss-islington
encukou authored and miss-islington committed Nov 8, 2024
commit 29fa44517d6fbc56d8a4e4dd7d07ead38653904e
2 changes: 1 addition & 1 deletion Lib/test/test_ssl.py
View file
Open in desktop