[3.12] gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#124959) by graingert · Pull Request #125466 · python/cpython · GitHub
Skip to content

[3.12] gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#124959)#125466

Merged
1st1 merged 3 commits intopython:3.12from
graingert:backport-d5dbbf4-3.12
Oct 17, 2024
Merged

[3.12] gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#124959)#125466
1st1 merged 3 commits intopython:3.12from
graingert:backport-d5dbbf4-3.12

Conversation

@graingert
Copy link
Copy Markdown
Contributor

@graingert graingert commented Oct 14, 2024

@graingert graingert changed the title gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#124959) [3.12] gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#124959) Oct 14, 2024
@graingert graingert closed this Oct 14, 2024
@graingert graingert reopened this Oct 14, 2024
@graingert graingert marked this pull request as ready for review October 14, 2024 15:45
@1st1
Copy link
Copy Markdown
Member

1st1 commented Oct 15, 2024

@graingert
Copy link
Copy Markdown
Contributor Author

What's this DO NOT MERGE label business?

@1st1 this was related to a failure on 3.14 (main) caused by a conflict with a different PR #124392

The do not merge label was added out of an abundance of caution assuming this PR was flaky when it is not. I removed the label

@1st1 1st1 merged commit 32d4579 into python:3.12 Oct 17, 2024
@graingert graingert deleted the backport-d5dbbf4-3.12 branch October 17, 2024 07:44
@gvanrossum
Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants