{{ message }}
gh-125196: Use PyUnicodeWriter for JSON encoder - #125249
Merged
Merged
Conversation
Replace the private _PyUnicodeWriter with the public PyUnicodeWriter.
eendebakpt
reviewed
Oct 10, 2024
Contributor
There was a problem hiding this comment.
I think this new code is cleaner than the old code. But PyTuple_Pack is a bit slow (see #118222), so we should measure whether this change makes an impact. Since this is not in one of the inner loops, I suspect the impact is really small.
Member
Author
There was a problem hiding this comment.
See my comment below. It's not faster, it's not slower. The change has no significant effect on performance.
Member
Author
There was a problem hiding this comment.
I don't think that PyTuple_Pack() is the performance bottleneck of this function.
I chose to use PyTuple_Pack() to avoid creating an incomplete tuple and then fill it. I prefer an atomic API which creates directly valid tuple.
Member
Author
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the private _PyUnicodeWriter with the public PyUnicodeWriter.