gh-125196: Add a free list to PyUnicodeWriter by vstinner · Pull Request #125227 · python/cpython · GitHub
Skip to content

gh-125196: Add a free list to PyUnicodeWriter - #125227

Merged
vstinner merged 2 commits into
python:mainfrom
vstinner:writer_freelist
Oct 10, 2024
Merged

gh-125196: Add a free list to PyUnicodeWriter#125227
vstinner merged 2 commits into
python:mainfrom
vstinner:writer_freelist

Conversation

@vstinner

@vstinner vstinner commented Oct 9, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Oct 9, 2024
Closed
@vstinner

vstinner commented Oct 9, 2024

Copy link
Copy Markdown
Member Author

@vstinner

vstinner commented Oct 9, 2024

Copy link
Copy Markdown
Member Author

@pitrou: That's one way to reduce the cost of the PyUnicodeWriter_Create() memory allocation.

@vstinner

vstinner commented Oct 9, 2024

Copy link
Copy Markdown
Member Author

cc @serhiy-storchaka

I started with a free list of 1 item. We may enlarge it later for nested function calls, like repr() of a list which contains lists (which may contain lists as well, etc.).

@vstinner

vstinner commented Oct 10, 2024

Copy link
Copy Markdown
Member Author

@vstinner
vstinner merged commit 1639d93 into python:main Oct 10, 2024
@vstinner
vstinner deleted the writer_freelist branch October 10, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vstinner