{{ message }}
gh-124309: Fix the AssertionError when using the happy_eyeballs_delay argument in open_connection - #124311
Closed
rruuaanng wants to merge 2 commits into
Closed
gh-124309: Fix the AssertionError when using the happy_eyeballs_delay argument in open_connection#124311rruuaanng wants to merge 2 commits into
rruuaanng wants to merge 2 commits into
Conversation
rruuaanng
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
September 22, 2024 04:28
rruuaanng
changed the title
rruuaanng
changed the title
Contributor
|
This change seems incorrect 1 test failed: |
Contributor
Author
I know, I'll take up this PR and look for a solution. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm looking for a better solution for this, if anyone finds one I can close this PR.