{{ message }}
Conversation
…nd compatibility changes from importlib_resources. (pythonGH-123028) (python#123051)" This reverts commit 5ac14ee. This commit should be re-applied after 3.13.0 final.
jaraco
enabled auto-merge (squash)
August 16, 2024 15:59
jaraco
disabled auto-merge
August 16, 2024 16:11
Member
Author
Member
|
@jaraco feel free to request a review from me in such cases. I do tend to keep up with the ongoing work in the |
Member
Author
|
An alternative to approving and merging this change could be to retroactively review and accept the changes for 3.13. I know we wouldn't normally apply such style-sync changes in an RC, but I also note that the AST doesn't change for the non-test code and changes only very modestly in tests. If @encukou would be okay with not applying this PR, that would be my preference. |
Member
|
I agree that, since the mistake is made, it's better to keep the style changes in than to revert them and re-introduce later. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 5ac14ee.
This commit should be re-applied after 3.13.0 final.