gh-121735: Fix module-adjacent references in zip files - #123037
Conversation
|
I'm a little apprehensive about the prospect of backporting this to Python 3.12, given the amount of refactoring that had to happen in the tests to make them viable. I may opt to backport the fix but limit the amount of changes backported to the tests, depending on how complicated it turns out to be. |
FFY00
left a comment
There was a problem hiding this comment.
This looks okay to me.
I don't really have any strong opinion regarding backporting the changes to 3.12. I agree it would be nicer to backport without the large test suite refactoring, but that isn't unreasonable to me if the changes don't end up applying cleanly. Not backporting the test suite changes also increases the possibility for test suite bugs to sneak into the 3.12 branch, as that won't be maintained as closely as the main branch. Additionally, it can also cause conflicts when backporting other fixes, so, eh, I guess I am +0.5 on backporting this PR as a whole.
|
@Gatsik - the implementation provided herein has already been reviewed and released as
It's not obvious to me from this fix what the failure mode is. I think I see it now - if the |
|
Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…H-123037) * pythongh-116608: Apply style and compatibility changes from importlib_metadata. * pythongh-121735: Ensure module-adjacent resources are loadable from a zipfile. * pythongh-121735: Allow all modules to be processed by the ZipReader. * Add blurb * Remove update-zips script, unneeded. * Remove unnecessary references to removed static fixtures. * Remove zipdata fixtures, unused. (cherry picked from commit ba687d9) Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
|
Sorry, @jaraco, I could not cleanly backport this to |

Merge after #123028.