gh-111178: Avoid calling functions from incompatible pointer types in `longobject.c` by picnixz · Pull Request #122972 · python/cpython · GitHub
Skip to content

gh-111178: Avoid calling functions from incompatible pointer types in longobject.c - #122972

Merged
encukou merged 1 commit into
python:mainfrom
picnixz:fix-arch-linux-usan-failure
Aug 14, 2024
Merged

gh-111178: Avoid calling functions from incompatible pointer types in longobject.c#122972
encukou merged 1 commit into
python:mainfrom
picnixz:fix-arch-linux-usan-failure

Conversation

@picnixz

@picnixz picnixz commented Aug 13, 2024

Copy link
Copy Markdown
Member

@picnixz

picnixz commented Aug 13, 2024

Copy link
Copy Markdown
Member Author

@encukou

encukou commented Aug 14, 2024

Copy link
Copy Markdown
Member

!buildbot Usan

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit cd63f58 🤖

The command will test the builders whose names match following regular expression: Usan

The builders matched are:

  • AMD64 Arch Linux Usan PR

@encukou

encukou commented Aug 14, 2024

Copy link
Copy Markdown
Member

Thank you for the fix! It looks good to merge if the buildbot passes.

No NEWS required; I agree with your triage.

@picnixz

picnixz commented Aug 14, 2024

Copy link
Copy Markdown
Member Author

So, the fix fixed it but since the compiler early exits, there are more errors appearing:

Objects/object.c:2892:5: runtime error: call to function MemoryError_dealloc through pointer to incorrect function type 'void (*)(struct _object *)'
/buildbot/buildarea/pull_request.pablogsal-arch-x86_64.clang-ubsan/build/Objects/exceptions.c:3391: note: MemoryError_dealloc defined here
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Objects/object.c:2892:5 in 

Should I try to fix the build bot in one go, or do we just merge this one, then fix compilation errors one by one? (this would affect the title of the PR as well btw and I don't think I'm able to run a build bot myself to check).

(I fear that the build bot will be failing until we fix all those kind of functions with explicit casts...)

See #123004 for the incremental fixes that I will make.

@encukou

encukou commented Aug 14, 2024

Copy link
Copy Markdown
Member

@encukou
encukou merged commit fe3e623 into python:main Aug 14, 2024
@picnixz
picnixz deleted the fix-arch-linux-usan-failure branch August 14, 2024 09:57
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants