{{ message }}
gh-111178: Avoid calling functions from incompatible pointer types in longobject.c - #122972
Merged
Merged
Conversation
Member
Author
Member
|
!buildbot Usan |
Member
|
Thank you for the fix! It looks good to merge if the buildbot passes. No NEWS required; I agree with your triage. |
Member
Author
|
So, the fix fixed it but since the compiler early exits, there are more errors appearing: Should I try to fix the build bot in one go, or do we just merge this one, then fix compilation errors one by one? (this would affect the title of the PR as well btw and I don't think I'm able to run a build bot myself to check). (I fear that the build bot will be failing until we fix all those kind of functions with explicit casts...) See #123004 for the incremental fixes that I will make. |
Member
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
…ype (pythonGH-122972) Make `long_hash` compatible with `hashfunc`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.