GH-122821: Simplify compilation of while statements to ensure consistency of offsets for sys.monitoring by markshannon · Pull Request #122934 · python/cpython · GitHub
Skip to content

GH-122821: Simplify compilation of while statements to ensure consistency of offsets for sys.monitoring - #122934

Merged
markshannon merged 4 commits into
python:mainfrom
faster-cpython:fix-122821
Aug 13, 2024
Merged

GH-122821: Simplify compilation of while statements to ensure consistency of offsets for sys.monitoring#122934
markshannon merged 4 commits into
python:mainfrom
faster-cpython:fix-122821

Conversation

@markshannon

@markshannon markshannon commented Aug 12, 2024

Copy link
Copy Markdown
Member

@markshannon

Copy link
Copy Markdown
Member Author

@python python deleted a comment from bedevere-bot Aug 12, 2024
@iritkatriel

iritkatriel commented Aug 12, 2024

Copy link
Copy Markdown
Member

It would be good to add a test in test_monitoring about the branch location issue.

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor nitpick.

Comment thread Misc/NEWS.d/next/Core_and_Builtins/2024-08-12-11-45-47.gh-issue-122821.WnAzTK.rst Outdated
…e-122821.WnAzTK.rst

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@markshannon
markshannon merged commit fe23f8e into python:main Aug 13, 2024
@picnixz

picnixz commented Aug 13, 2024

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants