{{ message }}
GH-113464: Speed up JIT builds - #122839
Merged
Merged
Conversation
Closed
savannahostrowski
approved these changes
Aug 9, 2024
savannahostrowski
left a comment
savannahostrowski
left a comment
Member
There was a problem hiding this comment.
My only question is how, if at all, memory usage is impacted by this change, given the independent compilation.
Otherwise, this is just a tiny comment about adding a comment.
Member
There was a problem hiding this comment.
Would it be good to add a comment here about why each of these is compiled independently (e.g., because of the performance benefit)? I'm not sure that would be abundantly clear if I just stumbled upon this code.
Member
Author
There was a problem hiding this comment.
Good idea, I'll add a comment.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current JIT build includes the code for every instruction when compiling each stencil, even though only one of the cases is used.
This extracts the desired cases and compiles them each in isolation, which makes JIT builds almost twice as fast (except on Windows, where I suspect we're still bound by subprocess creation time).