{{ message }}
gh-122681: remove m_atan2()/c_atan2() helpers - #122715
Merged
kumaraditya303 merged 3 commits intoAug 17, 2024
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Member
skirpichev
marked this pull request as ready for review
August 6, 2024 12:52
This comment was marked as outdated.
This comment was marked as outdated.
vstinner
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
Member
Author
|
No failures, related to this pr. |
vstinner
approved these changes
Aug 7, 2024
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM.
@skirpichev: Did you just create to see if removing the wrapper would work or not, or do you propose to remove it?
Member
Author
|
Yeah, I think we can remove it; testing with buildbots - for additional safety. But it's not urgent and I would appreciate @mdickinson blessing. Current workarounds fix only few functions in cmath. Missing bugreports - another indication, that underlying problems were fixed on affected systems. |
kumaraditya303
approved these changes
Aug 17, 2024
kumaraditya303
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
jeremyhylton
pushed a commit
to jeremyhylton/cpython
that referenced
this pull request
Aug 19, 2024
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.