{{ message }}
gh-117482: Fix the Slot Wrapper Inheritance Tests - #122248
Merged
ericsnowcurrently merged 6 commits intoJul 29, 2024
Merged
ericsnowcurrently merged 6 commits into
ericsnowcurrently merged 6 commits into
Conversation
This was referenced Jul 24, 2024
Member
Author
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 60ad88d 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests were only checking cases where the slot wrapper was present in the initial case. They were missing when the slot wrapper was added in the additional initializations. This fixes that.
I'll be backporting this to 3.13 and 3.12 manually.
int.__str__behaviour inside sub-interpreters #117482