{{ message }}
gh-117482: Fix Builtin Types Slot Wrappers When Embedded - #121636
Closed
ericsnowcurrently wants to merge 10 commits into
Closed
ericsnowcurrently wants to merge 10 commits into
ericsnowcurrently wants to merge 10 commits into
Conversation
ericsnowcurrently
added
skip news
needs backport to 3.13
Contributor
Member
Author
|
Yep. It's on my TODO list. 😄 |
ericsnowcurrently
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 8520cfc 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Contributor
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 8520cfc 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
ericsnowcurrently
marked this pull request as draft
August 12, 2024 22:44
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While gh-121602 solved most of the problem, it did not resolve the case where the runtime gets re-initialized. In that case, we end up in the same situation as before, where the inherited "tp" slots are set, which makes
add_operators()do the wrong thing. We fix that by resetting the static type to the preserved values during finalization. We also make sure the type substructs are preserved.(Given that this fix is for a more unlikely case, I'm inclined to not backport this to 3.12.)
int.__str__behaviour inside sub-interpreters #117482