gh-121266: Change dict check_lookup() return type to int by vstinner · Pull Request #121581 · python/cpython · GitHub
Skip to content

gh-121266: Change dict check_lookup() return type to int - #121581

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:dict_compare_int
Jul 17, 2024
Merged

gh-121266: Change dict check_lookup() return type to int#121581
vstinner merged 1 commit into
python:mainfrom
vstinner:dict_compare_int

Conversation

@vstinner

@vstinner vstinner commented Jul 10, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Jul 10, 2024
Closed
@vstinner vstinner mentioned this pull request Jul 10, 2024
Merged
@vstinner
vstinner merged commit 51da3df into python:main Jul 17, 2024
@vstinner
vstinner deleted the dict_compare_int branch July 17, 2024 19:52
@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Jul 18, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 18, 2024

Copy link
Copy Markdown

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 18, 2024
@vstinner @miss-islington
pythongh-121266: Change dict check_lookup() return type to int (pytho…
5ab87be 
…nGH-121581)

(cherry picked from commit 51da3df)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app

bedevere-app Bot commented Jul 18, 2024

Copy link
Copy Markdown

GH-121949 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 18, 2024
vstinner added a commit that referenced this pull request Jul 20, 2024
@miss-islington @vstinner
[3.13] gh-121266: Change dict check_lookup() return type to int (GH-1…
2fff3c4 
…21581) (#121949)

gh-121266: Change dict check_lookup() return type to int (GH-121581)
(cherry picked from commit 51da3df)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot

bedevere-bot commented Jul 20, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora 3.13 has failed when building commit 2fff3c4.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1403/builds/221) and take a look at the build logs.
  4. Check if the failure is related to this commit (2fff3c4) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1403/builds/221

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_inspect_keeps_globals_from_inspected_module - test.test_pyrepl.test_pyrepl.TestMain.test_inspect_keeps_globals_from_inspected_module

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.13.edelsohn-fedora-z/build/Lib/test/test_pyrepl/test_pyrepl.py", line 995, in _run_repl_globals_test
    self.fail(f"{var}= not found in output")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: FOO= not found in output


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.13.edelsohn-fedora-z/build/Lib/test/test_pyrepl/test_pyrepl.py", line 995, in _run_repl_globals_test
    self.fail(f"{var}= not found in output")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: __name__= not found in output

@bedevere-bot

bedevere-bot commented Jul 20, 2024

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane Awaiting requested review from methane methane is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @bedevere-bot