gh-130607: Extend and cleanup IPv6 tests by bazhil · Pull Request #121518 · python/cpython · GitHub
Skip to content

gh-130607: Extend and cleanup IPv6 tests - #121518

Merged
encukou merged 8 commits into
python:mainfrom
bazhil:extend_ipv6_tests
Feb 28, 2025
Merged

gh-130607: Extend and cleanup IPv6 tests#121518
encukou merged 8 commits into
python:mainfrom
bazhil:extend_ipv6_tests

Conversation

@bazhil

@bazhil bazhil commented Jul 8, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor
  1. Was added two test cases for IPv6 with part of IPv4.
  2. Add space in two lines (896, 897) between variable and '='

Hope this work make ipaddress better.

@ghost

ghost commented Jul 8, 2024 •
edited by ghost
Loading

Copy link
Copy Markdown

@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jul 8, 2024
@bedevere-app

bedevere-app Bot commented Jul 8, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-app Bot commented Jul 8, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bazhil bazhil changed the title Extend IPv6 tests and made little syntax refactoring Extend IPv6 tests and made little syntax refactoring skip issue skip news Jul 8, 2024
@bazhil bazhil changed the title Extend IPv6 tests and made little syntax refactoring skip issue skip news Extend IPv6 tests and made little syntax refactoring #skip issue #skip news Jul 8, 2024
@bedevere-app

bedevere-app Bot commented Jul 9, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-app Bot commented Feb 25, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

picnixz
picnixz reviewed Feb 25, 2025
View reviewed changes

@picnixz picnixz left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still want an issue for refactoring this but a skip news is fine. The issue should indicate which tests need to be refactored (essentially all those using == + assertTrue/False; we should use better assert methods) and why some need to be extended.

We can however improve even the testsdoing == by using assertEqual. Traceback will be nicer.

@picnixz picnixz changed the title Extend IPv6 tests and made little syntax refactoring #skip issue #skip news Extend and cleanup IPv6 tests Feb 25, 2025
@bazhil

bazhil commented Feb 26, 2025

Copy link
Copy Markdown
Contributor Author

@picnixz create an issue for this pull request #130607

@bazhil bazhil changed the title Extend and cleanup IPv6 tests [3.12] gh-130607: Extend and cleanup IPv6 tests Feb 26, 2025
@bazhil bazhil changed the title [3.12] gh-130607: Extend and cleanup IPv6 tests gh-130607: Extend and cleanup IPv6 tests Feb 26, 2025
encukou
encukou approved these changes Feb 27, 2025
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is an improvement; any refactoring can be done in a separate PR.

StanFromIreland
StanFromIreland approved these changes Feb 27, 2025
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :-)

@StanFromIreland

StanFromIreland commented Feb 28, 2025

Copy link
Copy Markdown
Member

You do not need to update the branch. That will
done by whoever is committing it.

@encukou
encukou merged commit 9f0879b into python:main Feb 28, 2025
@encukou encukou added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 28, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 28, 2025

Copy link
Copy Markdown

Thanks @bazhil for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Feb 28, 2025

Copy link
Copy Markdown

Thanks @bazhil for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 28, 2025
@bazhil @miss-islington
pythongh-130607: Extend and cleanup IPv6 tests (pythonGH-121518)
8b67270 
Extend IPv6 tests and made little syntax refactoring
(cherry picked from commit 9f0879b)

Co-authored-by: Ilya Bazhenov <31971067+bazhil@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Feb 28, 2025

Copy link
Copy Markdown

GH-130678 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 28, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 28, 2025
@bazhil @miss-islington
pythongh-130607: Extend and cleanup IPv6 tests (pythonGH-121518)
855c57e 
Extend IPv6 tests and made little syntax refactoring
(cherry picked from commit 9f0879b)

Co-authored-by: Ilya Bazhenov <31971067+bazhil@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Feb 28, 2025

Copy link
Copy Markdown

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Feb 28, 2025
encukou pushed a commit that referenced this pull request Feb 28, 2025
@miss-islington @bazhil
[3.12] gh-130607: Extend and cleanup IPv6 tests (GH-121518) (GH-130678)
d922aa8 
Extend IPv6 tests and made little syntax refactoring
(cherry picked from commit 9f0879b)

Co-authored-by: Ilya Bazhenov <31971067+bazhil@users.noreply.github.com>
encukou pushed a commit that referenced this pull request Feb 28, 2025
@miss-islington @bazhil
[3.13] gh-130607: Extend and cleanup IPv6 tests (GH-121518) (GH-130679)
9d825d4 
Extend IPv6 tests and made little syntax refactoring
(cherry picked from commit 9f0879b)

Co-authored-by: Ilya Bazhenov <31971067+bazhil@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments
@encukou encukou encukou approved these changes
@StanFromIreland StanFromIreland StanFromIreland approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bazhil @StanFromIreland @encukou @picnixz