[3.13] gh-121018: Ensure ArgumentParser.parse_args with exit_on_error=False raises instead of exiting when given unrecognized arguments (GH-121019) by miss-islington · Pull Request #121032 · python/cpython · GitHub
Skip to content

[3.13] gh-121018: Ensure ArgumentParser.parse_args with exit_on_error=False raises instead of exiting when given unrecognized arguments (GH-121019) #121032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 2 commits into from
Jun 26, 2024
+9 −2
Merged

[3.13] gh-121018: Ensure ArgumentParser.parse_args with exit_on_error=False raises instead of exiting when given unrecognized arguments (GH-121019) #121032

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8e2d55
gh-121018: Ensure ArgumentParser.parse_args with exit_on_error=False …
blhsing Jun 26, 2024
959a93b
Update 2024-06-26-03-04-24.gh-issue-121018.clVSc4.rst
serhiy-storchaka Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-121018: Ensure ArgumentParser.parse_args with exit_on_error=False … 
…raises instead of exiting when given unrecognized arguments (GH-121019)

(cherry picked from commit 0654336)

Co-authored-by: blhsing <blhsing@gmail.com>
  • Loading branch information
@blhsing @miss-islington
blhsing authored and miss-islington committed Jun 26, 2024
commit c8e2d55e218309800a3f1dcc38c1290a0be960c0
6 changes: 4 additions & 2 deletions Lib/argparse.py
View file
Open in desktop
3 changes: 3 additions & 0 deletions Lib/test/test_argparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6096,6 +6096,9 @@ def test_exit_on_error_with_bad_args(self):
with self.assertRaises(argparse.ArgumentError):
self.parser.parse_args('--integers a'.split())

def test_exit_on_error_with_unrecognized_args(self):
with self.assertRaises(argparse.ArgumentError):
self.parser.parse_args('--foo bar'.split())

def tearDownModule():
# Remove global references to avoid looking like we have refleaks.
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2024-06-26-03-04-24.gh-issue-121018.clVSc4.rst
View file
Open in desktop