gh-120782: Update internal type cache when reloading datetime - #120829
Conversation
| _datetime.time.max > _datetime.time.min | ||
| _datetime.datetime.max > _datetime.datetime.min | ||
| _datetime.timedelta.max > _datetime.timedelta.min | ||
| isinstance(_datetime.timezone.min, _datetime.tzinfo) |
There was a problem hiding this comment.
assert isinstance(_datetime.timezone.min, _datetime.tzinfo)
~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError
assert not isinstance(_datetime.timezone.min, _datetime.tzinfo)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError
Both fail, so this checks if it crashes or not. I agree this is not a good example.
There was a problem hiding this comment.
Given that the code looks a bit unusual, it would be worth adding a brief comment explaining that.
(Sorry I didn't notice this during my earlier review. Good catch, @JelleZijlstra.)
There was a problem hiding this comment.
Wouldn't it make sense to have these asserts actually check that the values are of the type they should be? The bug manifested itself as these values appearing to be objects of various random types.
There was a problem hiding this comment.
You could also assert that timezone.__dict__["min"] is timezone.min.
|
Thanks. I'll make a backport PR to 3.13 manually with an assertion to the test case. |
|
GH-120855 is a backport of this pull request to the 3.13 branch. |
…H-120829) (#120855) * [3.13] gh-120782: Update internal type cache when reloading datetime When reloading _datetime module, the single-phase version did not invoke the PyInit__datetime function, whereas the current multi-phase version updates the static types through the module init. The outdated static type cache in the interpreter state needs to be invalidated at the end of reloading the multi-phase module.
6 participants
When reloading
_datetimemodule, the single-phase version did not invoke thePyInit__datetimefunction, whereas the current multi-phase version updates the static types through the module init. The outdated static type cache in the interpreter state needs to be invalidated at the end of reloading the multi-phase module.test_datetimefails with a--foreverargument #120782