{{ message }}
GH-120804: Remove get_child_watcher and set_child_watcher from asyncio - #120818
Merged
Conversation
kumaraditya303
requested review from
1st1,
asvetlov,
gvanrossum and
willingc
as code owners
June 21, 2024 05:35
5 tasks
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
…rom asyncio (python#120818)
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…rom asyncio (python#120818)
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…rom asyncio (python#120818)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
get_child_watcherandset_child_watcherfrom asyncio. At some place currently we directly write topolicy._watcheras there are no apis to do that for testing. This is temporary and will change in subsequent PRs when subprocesses will be rewritten to not use child watchers at all and then this "hack" will become unnecessary and be removed.