{{ message }}
gh-120417: Fix "imported but unused" linter warnings - #120461
Merged
Merged
Conversation
Add __all__ to the following modules: collections.abc, importlib.machinery, importlib.util and xml.sax. Add also "# noqa: F401" in subprocess and xml.sax on two lines.
vstinner
requested review from
brettcannon,
ericsnowcurrently,
gpshead,
ncoghlan,
rhettinger and
warsaw
as code owners
June 13, 2024 17:14
rhettinger
removed their request for review
June 13, 2024 17:21
gpshead
approved these changes
Jun 13, 2024
hugovk
approved these changes
Jun 13, 2024
hugovk
left a comment
hugovk
left a comment
Member
There was a problem hiding this comment.
My only nitpick is to put them in alphabetical order, to make it easier to find an import when scanning the list.
Member
Author
Member
Author
|
I updated the PR:
|
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
It is easy to get __all__ de-synchronized with the module content. I think that all changed modules need tests for __all__. See existing tests that use support.check__all__.
Member
Author
serhiy-storchaka
approved these changes
Jun 14, 2024
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
LGTM. I tested that __all__ includes all non-underscored names except module names.
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
…0461) Add __all__ to the following modules: importlib.machinery, importlib.util and xml.sax. Add also "# noqa: F401" in collections.abc, subprocess and xml.sax. * Sort __all__; remove collections.abc.__all__; remove private names * Add tests
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…0461) Add __all__ to the following modules: importlib.machinery, importlib.util and xml.sax. Add also "# noqa: F401" in collections.abc, subprocess and xml.sax. * Sort __all__; remove collections.abc.__all__; remove private names * Add tests
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…0461) Add __all__ to the following modules: importlib.machinery, importlib.util and xml.sax. Add also "# noqa: F401" in collections.abc, subprocess and xml.sax. * Sort __all__; remove collections.abc.__all__; remove private names * Add tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
__all__to the following modules: collections.abc, importlib.machinery, importlib.util and xml.sax.Add also "# noqa: F401" in subprocess and xml.sax on two lines.