{{ message }}
gh-119726: JIT: re-use trampolines on AArch64 - #120250
Merged
Merged
Conversation
When emitting AArch64 trampolines at the end of every data stencil, re-use existent ones fot the same symbol. Fix the disassebly to reflect the "bl" instruction without the relocation.
5 tasks
brandtbucher
reviewed
Jun 8, 2024
brandtbucher
left a comment
brandtbucher
left a comment
Member
There was a problem hiding this comment.
Nice work! Just a few thoughts I had while looking it over:
brandtbucher
added
performance
Member
Contributor
Author
We've tested it on our internal CI and we didn't see any problems. We tested it against Linux AArch64/x86 and MacOS arm64. |
Member
Awesome. Want to open a PR to update |
Contributor
Author
brandtbucher
left a comment
brandtbucher
left a comment
Member
There was a problem hiding this comment.
Thanks! Just two more suggestions:
brandtbucher
approved these changes
Jun 19, 2024
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When emitting AArch64 trampolines at the end of every data stencil, re-use existent ones fot the same symbol.