gh-120242: Fix handling of `[setUp,tearDown]Class` in `test_datetime` by sobolevn · Pull Request #120243 · python/cpython · GitHub
Skip to content

gh-120242: Fix handling of [setUp,tearDown]Class in test_datetime - #120243

Merged
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-120242
Jun 8, 2024
Merged

gh-120242: Fix handling of [setUp,tearDown]Class in test_datetime#120243
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-120242

Conversation

@sobolevn

@sobolevn sobolevn commented Jun 7, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Now the example test from the original issue passes:

» ./python.exe -m test test_datetime -v -m test_example_bug
== CPython 3.14.0a0 (heads/main-dirty:6646a9da26d, Jun 7 2024, 13:34:08) [Clang 15.0.0 (clang-1500.3.9.4)]
== macOS-14.4.1-arm64-arm-64bit-Mach-O little-endian
== Python build: debug
== cwd: /Users/sobolev/Desktop/cpython2/build/test_python_worker_65090æ
== CPU count: 12
== encodings: locale=UTF-8 FS=utf-8
== resources: all test resources are disabled, use -u option to unskip tests

Using random seed: 485307049
0:00:00 load avg: 1.16 Run 1 test sequentially in a single process
0:00:00 load avg: 1.16 [1/1] test_datetime
test_example_bug (test.datetimetester.TestExample_Pure.test_example_bug) ... ok
test_example_bug (test.datetimetester.TestExample_Fast.test_example_bug) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.000s

OK

== Tests result: SUCCESS ==

1 test OK.

Total duration: 128 ms
Total tests: run=2 (filtered)
Total test files: run=1/1 (filtered)
Result: SUCCESS

@sobolevn
sobolevn requested review from abalkin and pganssle as code owners June 7, 2024 18:49
@bedevere-app bedevere-app Bot mentioned this pull request Jun 7, 2024
Closed
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Jun 7, 2024
@sobolevn sobolevn added skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jun 7, 2024
ericsnowcurrently
ericsnowcurrently reviewed Jun 7, 2024
View reviewed changes
Comment thread Lib/test/test_datetime.py Outdated
serhiy-storchaka
serhiy-storchaka approved these changes Jun 8, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sobolevn
sobolevn merged commit 95f4db8 into python:main Jun 8, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 8, 2024

Copy link
Copy Markdown

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2024
@sobolevn @miss-islington
pythongh-120242: Fix handling of [setUp,tearDown]Class in `test_dat…
112b20d 
…etime` (pythonGH-120243)

(cherry picked from commit 95f4db8)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@sobolevn

sobolevn commented Jun 8, 2024

Copy link
Copy Markdown
Member Author

Thanks for the reviews! 👍

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2024
@sobolevn @miss-islington
pythongh-120242: Fix handling of [setUp,tearDown]Class in `test_dat…
ea91f9d 
…etime` (pythonGH-120243)

(cherry picked from commit 95f4db8)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app

bedevere-app Bot commented Jun 8, 2024

Copy link
Copy Markdown

GH-120259 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 8, 2024
@bedevere-app

bedevere-app Bot commented Jun 8, 2024

Copy link
Copy Markdown

GH-120260 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jun 8, 2024
sobolevn added a commit that referenced this pull request Jun 8, 2024
@miss-islington @sobolevn
[3.12] gh-120242: Fix handling of [setUp,tearDown]Class in `test_da…
479655a 
…tetime` (GH-120243) (#120260)

gh-120242: Fix handling of `[setUp,tearDown]Class` in `test_datetime` (GH-120243)
(cherry picked from commit 95f4db8)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Jun 8, 2024
@miss-islington @sobolevn
[3.13] gh-120242: Fix handling of [setUp,tearDown]Class in `test_da…
863a0bd 
…tetime` (GH-120243) (#120259)

gh-120242: Fix handling of `[setUp,tearDown]Class` in `test_datetime` (GH-120243)
(cherry picked from commit 95f4db8)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot

bedevere-bot commented Jun 8, 2024

Copy link
Copy Markdown

noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@sobolevn @noahbkim
pythongh-120242: Fix handling of [setUp,tearDown]Class in `test_dat…
e251d72 
…etime` (python#120243)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@sobolevn @estyxx
pythongh-120242: Fix handling of [setUp,tearDown]Class in `test_dat…
0fb01a6 
…etime` (python#120243)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently left review comments
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn @bedevere-bot @ericsnowcurrently @serhiy-storchaka