gh-119698: fix symtable.Class.get_methods and document its behaviour correctly - #120151
Conversation
carljm
left a comment
There was a problem hiding this comment.
I think we should also test here that we do identify a PEP 695 generic method (e.g. def f[T](self): ...) as a method.
(I don't have strong opinions about whether we fix or document get_methods, but seems like we may as well fix if this much of the work is already done to fix.)
|
Thank you Carl, I have made the requested changes; please review again. The irony is that I worked on those blocks and I forgot about them in this PR... |
|
Thanks for making the requested changes! @carljm: please review the changes made to this pull request. |
7197e17 to
62d2d6d
Compare
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
…haviour correctly (python#120151) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
…haviour correctly (python#120151) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
…haviour correctly (python#120151) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

This is an alternative to #120148.
📚 Documentation preview 📚: https://cpython-previews--120151.org.readthedocs.build/