gh-126782: Support qualified referencing for `ntpath.abspath()` by nineteendo · Pull Request #119849 · python/cpython · GitHub
Skip to content

gh-126782: Support qualified referencing for ntpath.abspath() - #119849

Closed
nineteendo wants to merge 12 commits into
python:mainfrom
nineteendo:fix-ntpath.abspath
Closed

gh-126782: Support qualified referencing for ntpath.abspath()#119849
nineteendo wants to merge 12 commits into
python:mainfrom
nineteendo:fix-ntpath.abspath

Conversation

@nineteendo

@nineteendo nineteendo commented May 31, 2024

Copy link
Copy Markdown
Contributor

@nineteendo nineteendo changed the title gh-119826: Improve accuracy of `ntpath.normpath() & ntpath.abspath() gh-119826: Improve accuracy of ntpath.normpath() & ntpath.abspath() May 31, 2024
@nineteendo
nineteendo marked this pull request as ready for review May 31, 2024 13:34
@nineteendo nineteendo changed the title gh-119826: Improve accuracy of ntpath.normpath() & ntpath.abspath() gh-119826: Support qualified referencing for ntpath.abspath() Jun 2, 2024
@nineteendo

This comment was marked as outdated.

@nineteendo

This comment was marked as outdated.

@nineteendo

Copy link
Copy Markdown
Contributor Author

…024-05-31-12-44-38.gh-issue-126782.Atm9ol.rst
@nineteendo

Copy link
Copy Markdown
Contributor Author

I'll fix the drive relative paths in a separate PR.

@ZeroIntensity

Copy link
Copy Markdown
Member

Two notes:

  • Please don't change the target issue after the PR has been opened, it makes it harder to track discussion.
  • I'd really prefer that this PR get closed and reopened as a fresh PR under the new issue. Incorrectly rebasing triggers a review from all the codeowners, and they don't get unsubscribed even after their review request is removed.

@nineteendo

Copy link
Copy Markdown
Contributor Author

Sorry for the chaos.

@nineteendo

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants