{{ message }}
bpo-31904: Add cross-build support for VxWorks RTOS - #11968
Merged
Merged
Conversation
vstinner
reviewed
Feb 21, 2019
vstinner
reviewed
Feb 22, 2019
vstinner
requested changes
Feb 25, 2019
Contributor
Author
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
vstinner
reviewed
Feb 26, 2019
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM except of 2 minor changes: please fix NEWS entry and variable name.
| return sys.platform | ||
| host_platform = get_platform() | ||
|
|
||
| _vxworks = ('vxworks' in host_platform) |
Member
There was a problem hiding this comment.
Please rename the variable to VXWORKS to better distinguish local and global variables in functions below.
By the way, I would also prefer to rename host_platform to HOST_PLATFORM for the same reason, but it should be done in a separated PR.
Contributor
Author
There was a problem hiding this comment.
Just to confirm: all the variables that are not supposed to be modified should be defined as constants, right? If this is true, besides host_platform, cross_compiling is another one to fix. I looked through PEP-8 but didn't find the guidance.
Contributor
Author
Out of curiosity, does CPython run LGTM analysis as well? |
Member
Are you talking about lgtm.com? I know that Mark Shannon is working for this company, and I know that CPython is scanned by lgtm.com. Sadly, I never looked at it. |
Member
Ah, I found it: https://lgtm.com/projects/g/python/cpython/ |
Member
|
Thanks @pxinwr, I merged your PR ;-) |
|
|
|
|
|
|
|
Member
I wrote PR #12068 as a follow-up of this PR. |
Member
This was referenced Mar 1, 2019
This was referenced Mar 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables cpython build system to cross-build for VxWorks RTOS. More and full support on modules for VxWorks will continuously be added by the coming PRs.
VxWorks is a product developed and owned by Wind River. For VxWorks introduction or more details, go to https://www.windriver.com/products/vxworks/
Wind River will have a dedicated engineering team to contribute to the support as maintainers.
We already have a working buildbot worker internally, but has not bound to master. We will check the process for the buildbot, then add it.
https://bugs.python.org/issue31904