{{ message }}
gh-74929: PEP 667 C API documentation - #119379
Merged
Merged
Conversation
ncoghlan
added
docs
ncoghlan
requested review from
ericsnowcurrently,
gvanrossum and
markshannon
as code owners
May 22, 2024 06:36
Contributor
Author
ncoghlan
commented
May 22, 2024
| // with the initial value set when the frame was created... | ||
| // (unlikely) ...or it was set to some initial value by | ||
| // an earlier call to PyFrame_LocalsToFast(). | ||
| // (unlikely) ...or it was set via the f_locals proxy. |
Contributor
Author
There was a problem hiding this comment.
I'm pretty sure this "set externally" loophole still exists, it's just accessed slightly differently now.
ncoghlan
commented
May 25, 2024
Contributor
Author
|
I've kept the reference out to the PEP for details of the C API changes, so I'll submit a PR there that skips listing PR posted: python/peps#3793 |
encukou
reviewed
May 30, 2024
Contributor
Author
|
I'll leave this another couple of days to give @markshannon and @gaogaotiantian a further chance to comment, but I'll make sure this and the related PR to the PEP are merged before beta2 next week. |
picnixz
reviewed
May 30, 2024
picnixz
left a comment
picnixz
left a comment
Member
There was a problem hiding this comment.
Small nitpicks for consistency.
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 1, 2024
* Add docs for new APIs * Add soft-deprecation notices * Add What's New porting entries * Update comments referencing `PyFrame_LocalsToFast()` to mention the proxy instead * Other related cleanups found when looking for refs to the deprecated APIs (cherry picked from commit 3859e09) Co-authored-by: Alyssa Coghlan <ncoghlan@gmail.com>
barneygale
pushed a commit
to barneygale/cpython
that referenced
this pull request
Jun 5, 2024
* Add docs for new APIs * Add soft-deprecation notices * Add What's New porting entries * Update comments referencing `PyFrame_LocalsToFast()` to mention the proxy instead * Other related cleanups found when looking for refs to the deprecated APIs
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
* Add docs for new APIs * Add soft-deprecation notices * Add What's New porting entries * Update comments referencing `PyFrame_LocalsToFast()` to mention the proxy instead * Other related cleanups found when looking for refs to the deprecated APIs
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
* Add docs for new APIs * Add soft-deprecation notices * Add What's New porting entries * Update comments referencing `PyFrame_LocalsToFast()` to mention the proxy instead * Other related cleanups found when looking for refs to the deprecated APIs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--119379.org.readthedocs.build/