{{ message }}
gh-119292: Add job to jit.yml to build and test with --disable-gil - #119293
Merged
Conversation
Member
Author
hugovk
reviewed
May 21, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Member
Author
|
I suppose this could also be implemented as a matrix entry using |
sobolevn
reviewed
May 21, 2024
| - name: Build with JIT enabled and GIL disabled | ||
| run: | | ||
| sudo bash -c "$(wget -O - https://apt.llvm.org/llvm.sh)" ./llvm.sh 18 | ||
| export PATH="$(llvm-config-18 --bindir):$PATH" |
Member
There was a problem hiding this comment.
Opinions: should we add --with-pydebug? Maybe test both modes?
Member
There was a problem hiding this comment.
I think it's fine to leave this as-is (just one --with-pydebug build).
brandtbucher
approved these changes
May 21, 2024
brandtbucher
left a comment
brandtbucher
left a comment
Member
There was a problem hiding this comment.
Great idea.
One suggestion:
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
brandtbucher
added
tests
|
Thanks @savannahostrowski for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 21, 2024
…il (pythonGH-119293) (cherry picked from commit c4722cd) Co-authored-by: Savannah Ostrowski <savannahostrowski@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…il (pythonGH-119293) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alrighty, so I added a very basic job to test that we don't regress things as the JIT and free threading work evolves. I split the build and test into separate steps, so we have a little finer granularity on failures (it's just slightly prettier!). I also opted not to use
strategy/matrixto pass in the LLVM version since we only support 18 today. I can add that in if folks feel strongly if we want to keep things very consistent with the other job, but I was going for simple 😄jit.ymlto build and test with--disable-gil#119292