{{ message }}
gh-112075: Fix dict thread safety issues - #119288
Merged
Merged
Conversation
Kronuz
force-pushed
the
dict_thread_safety
branch
2 times, most recently
from
May 21, 2024 01:59
fbd9677 to
22279c0
Compare
Kronuz
force-pushed
the
dict_thread_safety
branch
from
May 21, 2024 15:37
22279c0 to
dc2c785
Compare
Kronuz
marked this pull request as ready for review
May 21, 2024 17:37
DinoV
reviewed
May 22, 2024
Kronuz
force-pushed
the
dict_thread_safety
branch
from
May 24, 2024 02:03
dc2c785 to
b98504f
Compare
Kronuz
force-pushed
the
dict_thread_safety
branch
from
May 24, 2024 02:06
b98504f to
2eeb71a
Compare
Contributor
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 9, 2024
Fix dict thread safety issues (cherry picked from commit f0ed186) Co-authored-by: Germán Méndez Bravo <kronuz@fb.com>
|
GH-121545 is a backport of this pull request to the 3.13 branch. |
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Fix dict thread safety issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
For dicts, there are a myriad of variables that are atomics. i.e.:
All of these can be accessed in write or read mode. When these are being accessed in write mode, regardless of the status of the dictionary lock, the write should be an atomic store. All reads must be atomic loads if the lock is not held, or can be non-atomic reads otherwise.
This diff goes through all of the
ma_useduse cases and makes sure this holds true.Test Plan:
./configure --disable-gil --with-thread-sanitizer --with-pydebug make -j env TSAN_OPTIONS=suppressions=Tools/tsan/suppressions_free_threading.txt ./python -m test --tsan -j4All tests passing, no related TSAN issues.
dictobjects thread-safe in--disable-gilbuilds #112075