gh-119189: Fix the fraction module so that __rpow__ works on arbitrary classes. by zitterbewegung · Pull Request #119242 · python/cpython · GitHub
Skip to content

gh-119189: Fix the fraction module so that __rpow__ works on arbitrary classes. - #119242

Merged
serhiy-storchaka merged 14 commits into
python:mainfrom
zitterbewegung:fix-issue-119189
May 31, 2024
Merged

gh-119189: Fix the fraction module so that __rpow__ works on arbitrary classes.#119242
serhiy-storchaka merged 14 commits into
python:mainfrom
zitterbewegung:fix-issue-119189

Conversation

@zitterbewegung

@zitterbewegung zitterbewegung commented May 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

gh-119189: Fix the fraction module so that rpow works on arbitrary classes.

 The fraction module implicitly casted float if __rpow__ was implemented in your class when raising a fraction to a power. Now we replace the cast to float and instead check if it is a float or complex  and if the class isn't it will raise an exception.

@zitterbewegung zitterbewegung changed the title Fix the fraction module so that __rpow__ works on arbitrary classes. gh-119189: Fix the fraction module so that __rpow__ works on arbitrary classes. May 20, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 20, 2024
Closed
@zitterbewegung
Fix the fraction module so that __rpow__ works on arbitrary classes.
1de7a44 
The fraction module implicitly casted float if __rpow__ was implemented in your class when raising a fraction to a power. Now it isn't done but will raise an exception if __rpow__ isn't implemented.
serhiy-storchaka
serhiy-storchaka approved these changes May 21, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update tests.

Also, I think that the text of the NEWS entry should be rewritten. It's hard to understand right now, I'm not even sure if it's correct at all.

serhiy-storchaka
serhiy-storchaka requested changes May 22, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update tests and rewrite the NEWS entry.

@bedevere-app

bedevere-app Bot commented May 22, 2024

Copy link
Copy Markdown

@zitterbewegung

zitterbewegung commented May 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Okay I will update tests.

@zitterbewegung

zitterbewegung commented May 28, 2024

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-app

bedevere-app Bot commented May 28, 2024

Copy link
Copy Markdown

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

@bedevere-app
bedevere-app Bot requested a review from serhiy-storchaka May 28, 2024 12:20
@serhiy-storchaka

serhiy-storchaka commented May 28, 2024

Copy link
Copy Markdown
Member

Tests are still failing. You have to make them pass.

@zitterbewegung

zitterbewegung commented May 29, 2024

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-app

bedevere-app Bot commented May 29, 2024

Copy link
Copy Markdown

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

serhiy-storchaka
serhiy-storchaka reviewed May 29, 2024
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2024-05-20-13-48-37.gh-issue-119189.dhJVs5.rst Outdated
Comment thread Lib/test/test_fractions.py
@zitterbewegung

zitterbewegung commented May 30, 2024

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-app

bedevere-app Bot commented May 30, 2024

Copy link
Copy Markdown

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

@bedevere-app
bedevere-app Bot requested a review from serhiy-storchaka May 30, 2024 00:28
serhiy-storchaka
serhiy-storchaka approved these changes May 30, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution @zitterbewegung.

@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) May 30, 2024 10:30
@serhiy-storchaka
serhiy-storchaka merged commit b9965ef into python:main May 31, 2024
@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels May 31, 2024
@miss-islington-app

miss-islington-app Bot commented May 31, 2024

Copy link
Copy Markdown

Thanks @zitterbewegung for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented May 31, 2024

Copy link
Copy Markdown

Thanks @zitterbewegung for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2024
@zitterbewegung @miss-islington
pythongh-119189: Fix the power operator for Fraction (pythonGH-119242)
490062a 
When using the ** operator or pow() with Fraction as the base
and an exponent that is not rational, a float, or a complex, the
fraction is no longer converted to a float.
(cherry picked from commit b9965ef)

Co-authored-by: Joshua Herman <30265+zitterbewegung@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2024
@zitterbewegung @miss-islington
pythongh-119189: Fix the power operator for Fraction (pythonGH-119242)
e895b00 
When using the ** operator or pow() with Fraction as the base
and an exponent that is not rational, a float, or a complex, the
fraction is no longer converted to a float.
(cherry picked from commit b9965ef)

Co-authored-by: Joshua Herman <30265+zitterbewegung@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented May 31, 2024

Copy link
Copy Markdown

GH-119835 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 31, 2024
@bedevere-app

bedevere-app Bot commented May 31, 2024

Copy link
Copy Markdown

GH-119836 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 31, 2024
@serhiy-storchaka

serhiy-storchaka commented May 31, 2024

Copy link
Copy Markdown
Member

noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@zitterbewegung @noahbkim
pythongh-119189: Fix the power operator for Fraction (pythonGH-119242)
d3b5c69 
When using the ** operator or pow() with Fraction as the base
and an exponent that is not rational, a float, or a complex, the
fraction is no longer converted to a float.
serhiy-storchaka pushed a commit that referenced this pull request Jul 16, 2024
@miss-islington @zitterbewegung
[3.12] gh-119189: Fix the power operator for Fraction (GH-119242) (GH…
d4f57cc 
…-119835)

When using the ** operator or pow() with Fraction as the base
and an exponent that is not rational, a float, or a complex, the
fraction is no longer converted to a float.
(cherry picked from commit b9965ef)

Co-authored-by: Joshua Herman <30265+zitterbewegung@users.noreply.github.com>
serhiy-storchaka pushed a commit that referenced this pull request Jul 16, 2024
@miss-islington @zitterbewegung
[3.13] gh-119189: Fix the power operator for Fraction (GH-119242) (GH…
d02adec 
…-119836)

When using the ** operator or pow() with Fraction as the base
and an exponent that is not rational, a float, or a complex, the
fraction is no longer converted to a float.
(cherry picked from commit b9965ef)

Co-authored-by: Joshua Herman <30265+zitterbewegung@users.noreply.github.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@zitterbewegung @estyxx
pythongh-119189: Fix the power operator for Fraction (pythonGH-119242)
5e16e85 
When using the ** operator or pow() with Fraction as the base
and an exponent that is not rational, a float, or a complex, the
fraction is no longer converted to a float.
scoder added a commit to scoder/quicktions that referenced this pull request Nov 28, 2024
@scoder
Fix the power operator for non float/complex values.
509036c 
See python/cpython#119242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zitterbewegung @serhiy-storchaka