{{ message }}
gh-119189: Add more tests for mixed Fraction arithmetic - #119236
Merged
serhiy-storchaka merged 2 commits intoMay 20, 2024
Merged
gh-119189: Add more tests for mixed Fraction arithmetic#119236serhiy-storchaka merged 2 commits into
serhiy-storchaka merged 2 commits into
Conversation
mdickinson
approved these changes
May 20, 2024
mdickinson
left a comment
Member
There was a problem hiding this comment.
LGTM; two nitpick-level comments.
serhiy-storchaka
force-pushed
the
tests-fractions-mixed-arithmetic
branch
from
May 20, 2024 18:37
dc34aa1 to
c1f6081
Compare
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 20, 2024
…GH-119236) (cherry picked from commit fe67af1) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 20, 2024
…GH-119236) (cherry picked from commit fe67af1) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-119255 is a backport of this pull request to the 3.13 branch. |
|
GH-119256 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
May 20, 2024
serhiy-storchaka
added a commit
that referenced
this pull request
May 20, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Contributor
|
I noticed that the newly added tests are written the wrong way around. When a test fails, it says something like Note how versus |
scoder
added a commit
to scoder/quicktions
that referenced
this pull request
Nov 28, 2024
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.