{{ message }}
gh-119121: Fix and test async.staggered.staggered_race - #119173
Merged
Conversation
sobolevn
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
May 19, 2024 10:12
gvanrossum
approved these changes
May 20, 2024
JelleZijlstra
approved these changes
May 20, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 20, 2024
…nGH-119173) (cherry picked from commit 16b46eb) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-119206 is a backport of this pull request to the 3.13 branch. |
sobolevn
added a commit
that referenced
this pull request
May 20, 2024
Kronuz
pushed a commit
to Kronuz/cpython
that referenced
this pull request
May 20, 2024
…pythonGH-119173) (python#119206) pythongh-119121: Fix and test `async.staggered.staggered_race` (pythonGH-119173) (cherry picked from commit 16b46eb) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a couple of tests for this function as well, to prevent simple future regressions.
Please, note that this set of tests is clearly not enough to cover all the cases in this function. Right now it only covers several simple use-cases. In the future we can also test:
loop=argument__debug__routedelaycorner casesBut, I think that testing green path is good enough for now.
I can commit more tests in the next PRs, since they will require quite a lot of effort.
Refs #114282
This PR does need a 3.13 backport.
asyncio.staggeredis missingtypingimport #119121