gh-118643: Fix AttributeError in the email module by serhiy-storchaka · Pull Request #119099 · python/cpython · GitHub
Skip to content

gh-118643: Fix AttributeError in the email module - #119099

Merged
serhiy-storchaka merged 3 commits into
python:mainfrom
serhiy-storchaka:email-comma-after-fold
May 22, 2024
Merged

gh-118643: Fix AttributeError in the email module#119099
serhiy-storchaka merged 3 commits into
python:mainfrom
serhiy-storchaka:email-comma-after-fold

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 16, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Fix regression introduced in gh-100884: AttributeError when re-fold a long address list.

Also fix more cases of incorrect encoding of the address separator in the address list missed in gh-100884.

@serhiy-storchaka
pythongh-118643: Fix AttributeError in the email module
ad85b83 
Fix regression introduced in pythongh-100884: AttributeError when re-fold a long
address list.

Also fix more cases of incorrect encoding of the address separator in the
address list missed in pythongh-100884.
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels May 16, 2024
@serhiy-storchaka
serhiy-storchaka requested a review from a team as a code owner May 16, 2024 14:49
@bedevere-app bedevere-app Bot mentioned this pull request May 16, 2024
Closed
@serhiy-storchaka

serhiy-storchaka commented May 16, 2024

Copy link
Copy Markdown
Member Author

@pablogamboa

pablogamboa commented May 16, 2024

Copy link
Copy Markdown
Contributor

Think that was for @pablogsal !

@serhiy-storchaka

serhiy-storchaka commented May 16, 2024

Copy link
Copy Markdown
Member Author

Sorry. 🤦‍♂️ I think it is not the first time of referring the wrong Pablo. 😉

@mgmacias95

mgmacias95 commented May 16, 2024

Copy link
Copy Markdown
Contributor

Hello @serhiy-storchaka,

I just tested this with the email that originally motivated me to open #118643 and the result is not correct. I will come back tomorrow with more details on exactly what is happening.

@mgmacias95

mgmacias95 commented May 17, 2024

Copy link
Copy Markdown
Contributor

Hello again,

I think I was a bit sleepy when I tested this last night 😅 because I tested this again this morning and it worked as expected. Sorry for the noise and thank you for looking into this!

Hello @serhiy-storchaka,

I just tested this with the email that originally motivated me to open #118643 and the result is not correct. I will come back tomorrow with more details on exactly what is happening.

mgmacias95
mgmacias95 reviewed May 17, 2024
View reviewed changes
Comment thread Lib/email/_header_value_parser.py Outdated
@serhiy-storchaka @mgmacias95
Update Lib/email/_header_value_parser.py
62125d7 
Co-authored-by: Marta Gómez Macías <mgmacias@google.com>
@serhiy-storchaka

serhiy-storchaka commented May 17, 2024

Copy link
Copy Markdown
Member Author

Thank you @mgmacias95 for testing this with real world examples.

@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) May 22, 2024 09:53
@serhiy-storchaka
serhiy-storchaka merged commit 858b9e8 into python:main May 22, 2024
@miss-islington-app

miss-islington-app Bot commented May 22, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2024
@serhiy-storchaka @miss-islington
pythongh-118643: Fix AttributeError in the email module (pythonGH-119099
6d4b54f 
)

Fix regression introduced in pythongh-100884: AttributeError when re-fold a long
address list.

Also fix more cases of incorrect encoding of the address separator in the
address list missed in pythongh-100884.
(cherry picked from commit 858b9e8)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2024
@serhiy-storchaka @miss-islington
pythongh-118643: Fix AttributeError in the email module (pythonGH-119099
d111cba 
)

Fix regression introduced in pythongh-100884: AttributeError when re-fold a long
address list.

Also fix more cases of incorrect encoding of the address separator in the
address list missed in pythongh-100884.
(cherry picked from commit 858b9e8)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app

bedevere-app Bot commented May 22, 2024

Copy link
Copy Markdown

GH-119389 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 22, 2024
@miss-islington-app

miss-islington-app Bot commented May 22, 2024

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 858b9e85fcdd495947c9e892ce6e3734652c48f2 3.11

@bedevere-app

bedevere-app Bot commented May 22, 2024

Copy link
Copy Markdown

GH-119390 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 22, 2024
@serhiy-storchaka
serhiy-storchaka deleted the email-comma-after-fold branch May 22, 2024 11:04
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 22, 2024
@serhiy-storchaka
[3.11] pythongh-118643: Fix AttributeError in the email module (pytho…
9bfb6ae 
…nGH-119099)

Fix regression introduced in pythongh-100884: AttributeError when re-fold a long
address list.

Also fix more cases of incorrect encoding of the address separator in the
address list missed in pythongh-100884.
(cherry picked from commit 858b9e8)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app

bedevere-app Bot commented May 22, 2024

Copy link
Copy Markdown

GH-119393 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label May 22, 2024
serhiy-storchaka added a commit that referenced this pull request May 22, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-118643: Fix AttributeError in the email module (GH-119099) (G…
6892b40 
…H-119389)

Fix regression introduced in gh-100884: AttributeError when re-fold a long
address list.

Also fix more cases of incorrect encoding of the address separator in the
address list missed in gh-100884.
(cherry picked from commit 858b9e8)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request May 22, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-118643: Fix AttributeError in the email module (GH-119099) (G…
8c96850 
…H-119390)

Fix regression introduced in gh-100884: AttributeError when re-fold a long
address list.

Also fix more cases of incorrect encoding of the address separator in the
address list missed in gh-100884.
(cherry picked from commit 858b9e8)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
pablogsal pushed a commit that referenced this pull request May 23, 2024
@serhiy-storchaka
[3.11] gh-118643: Fix AttributeError in the email module (GH-119099) (#…
4762b36 
…119393)

Fix regression introduced in gh-100884: AttributeError when re-fold a long
address list.

Also fix more cases of incorrect encoding of the address separator in the
address list missed in gh-100884.
(cherry picked from commit 858b9e8)
@bedevere-bot

bedevere-bot commented May 23, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL8 FIPS Only Blake2 Builtin Hash 3.11 has failed when building commit 4762b36.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/962/builds/1515) and take a look at the build logs.
  4. Check if the failure is related to this commit (4762b36) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/962/builds/1515

Failed tests:

  • test.test_multiprocessing_fork.test_processes
  • test.test_multiprocessing_forkserver.test_processes
  • test.test_multiprocessing_spawn.test_processes

Failed subtests:

  • test_empty_authkey - test.test_multiprocessing_forkserver.test_processes.WithProcessesTestListener.test_empty_authkey
  • test_empty_authkey - test.test_multiprocessing_fork.test_processes.WithProcessesTestListener.test_empty_authkey
  • test_empty_authkey - test.test_multiprocessing_spawn.test_processes.WithProcessesTestListener.test_empty_authkey

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.11.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/test/_test_multiprocessing.py", line 3483, in test_empty_authkey
    with listener.accept() as d:
         ^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.11.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/multiprocessing/connection.py", line 482, in accept
    deliver_challenge(c, self._authkey)
  File "/home/buildbot/buildarea/3.11.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/multiprocessing/connection.py", line 756, in deliver_challenge
    digest = hmac.new(authkey, message, 'md5').digest()
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.11.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/hmac.py", line 184, in new
    return HMAC(key, msg, digestmod)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.11.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/hmac.py", line 60, in __init__
    self._init_hmac(key, msg, digestmod)
  File "/home/buildbot/buildarea/3.11.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/hmac.py", line 67, in _init_hmac
    self._hmac = _hashopenssl.hmac_new(key, msg, digestmod=digestmod)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: no reason supplied


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.11.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/threading.py", line 1045, in _bootstrap_inner
    self.run()
  File "/home/buildbot/buildarea/3.11.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/threading.py", line 982, in run
    self._target(*self._args, **self._kwargs)
  File "/home/buildbot/buildarea/3.11.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/test/_test_multiprocessing.py", line 3474, in run
    client = self.connection.Client(addr, authkey=authkey)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.11.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/multiprocessing/connection.py", line 525, in Client
    answer_challenge(c, authkey)
  File "/home/buildbot/buildarea/3.11.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/multiprocessing/connection.py", line 772, in answer_challenge
    digest = hmac.new(authkey, message, 'md5').digest()
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.11.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/hmac.py", line 184, in new
    return HMAC(key, msg, digestmod)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.11.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/hmac.py", line 60, in __init__
    self._init_hmac(key, msg, digestmod)
  File "/home/buildbot/buildarea/3.11.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/hmac.py", line 67, in _init_hmac
    self._hmac = _hashopenssl.hmac_new(key, msg, digestmod=digestmod)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: no reason supplied
ERROR

@bedevere-bot

bedevere-bot commented May 23, 2024

Copy link
Copy Markdown

@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@serhiy-storchaka @estyxx
pythongh-118643: Fix AttributeError in the email module (pythonGH-119099
c068bee 
)

Fix regression introduced in pythongh-100884: AttributeError when re-fold a long
address list.

Also fix more cases of incorrect encoding of the address separator in the
address list missed in pythongh-100884.
@medmunds medmunds mentioned this pull request Feb 27, 2025
Merged
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mgmacias95 mgmacias95 mgmacias95 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @pablogamboa @mgmacias95 @bedevere-bot