Rename typing._collect_parameters - #118900
Conversation
function. Unfortunately, released versions of typing_extensions
monkeypatch this function without the extra parameter, which makes
it so things break badly if current main is used with typing_extensions.
```
% ~/py/cpython/python.exe test_typing_extensions.py
Traceback (most recent call last):
File "/Users/jelle/py/typing_extensions/src/test_typing_extensions.py", line 42, in <module>
from _typed_dict_test_helper import Foo, FooGeneric, VeryAnnotated
File "/Users/jelle/py/typing_extensions/src/_typed_dict_test_helper.py", line 17, in <module>
class FooGeneric(TypedDict, Generic[T]):
~~~~~~~^^^
File "/Users/jelle/py/cpython/Lib/typing.py", line 431, in inner
return func(*args, **kwds)
File "/Users/jelle/py/cpython/Lib/typing.py", line 1243, in _generic_class_getitem
return _GenericAlias(cls, args)
File "/Users/jelle/py/cpython/Lib/typing.py", line 1420, in __init__
self.__parameters__ = _collect_parameters(
~~~~~~~~~~~~~~~~~~~^
args,
^^^^^
enforce_default_ordering=enforce_default_ordering,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
)
^
TypeError: _collect_parameters() got an unexpected keyword argument 'enforce_default_ordering'
```
Fortunately, the monkeypatching is not needed on Python 3.13, because CPython
now implements PEP 696. By renaming the function, we prevent the monkeypatch
from breaking typing.py internals.
I think that error shows up only if you use
I think we could address this by keeping an alias |
|
Okay, sounds reasonable.
Or we could do this in the --- a/Lib/typing.py
+++ b/Lib/typing.py
@@ -3770,6 +3770,9 @@ def __getattr__(attr):
elif attr in {"ContextManager", "AsyncContextManager"}:
import contextlib
obj = _alias(getattr(contextlib, f"Abstract{attr}"), 2, name=attr, defaults=(bool | None,))
+ elif attr == "_collect_parameters":
+ do_the_deprecation_warning()
+ return _collect_type_parameters
else:
raise AttributeError(f"module {__name__!r} has no attribute {attr!r}")
globals()[attr] = obj |
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Unfortunately, released versions of typing_extensions monkeypatch this function without the extra parameter, which makes it so things break badly if current main is used with typing_extensions. Fortunately, the monkeypatching is not needed on Python 3.13, because CPython now implements PEP 696. By renaming the function, we prevent the monkeypatch from breaking typing.py internals. We keep the old name (raising a DeprecationWarning) to help other external users who call it. (cherry picked from commit ec9d12b) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
GH-118917 is a backport of this pull request to the 3.13 branch. |
Unfortunately, released versions of typing_extensions monkeypatch this function without the extra parameter, which makes it so things break badly if current main is used with typing_extensions. Fortunately, the monkeypatching is not needed on Python 3.13, because CPython now implements PEP 696. By renaming the function, we prevent the monkeypatch from breaking typing.py internals. We keep the old name (raising a DeprecationWarning) to help other external users who call it.
3 participants
function. Unfortunately, released versions of typing_extensions
monkeypatch this function without the extra parameter, which makes
it so things break badly if current main is used with typing_extensions.
Fortunately, the monkeypatching is not needed on Python 3.13, because CPython
now implements PEP 696. By renaming the function, we prevent the monkeypatch
from breaking typing.py internals.