{{ message }}
gh-117657: Don't specialize RESUME_CHECK when specialization is disabled - #118349
Merged
Conversation
Fidget-Spinner
marked this pull request as ready for review
April 27, 2024 16:24
Fidget-Spinner
changed the title
swtaarrs
approved these changes
Apr 30, 2024
swtaarrs
left a comment
swtaarrs
left a comment
Member
There was a problem hiding this comment.
Code looks good to me, but it might make sense to change the title to something like "Don't specialize RESUME_CHECK when specialization is disabled", which is what this is really doing. It's a good fix independent of free-threading concerns.
Fidget-Spinner
changed the title
Member
Author
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was showing up as a race in tsan. Though other races still bubble up with vectorcall so we cant remove it from the ignore list for now.