iframe-proxy

corona10 · 2024-04-18T15:46:42Z

Issue: Make set thread-safe in --disable-gil builds #112069

corona10 · 2024-04-18T15:49:54Z

tp_richcompare already set locks for two sets, so making PySet_GET_SIZE to be atomic safe will be enough.

Lines 2094 to 2111 in 94444ea

    
           case Py_EQ: 
        
               if (PySet_GET_SIZE(v) != PySet_GET_SIZE(w)) 
        
                   Py_RETURN_FALSE; 
        
               if (v->hash != -1  && 
        
                   ((PySetObject *)w)->hash != -1 && 
        
                   v->hash != ((PySetObject *)w)->hash) 
        
                   Py_RETURN_FALSE; 
        
               return set_issubset(v, w); 
        
           case Py_NE: 
        
               r1 = set_richcompare(v, w, Py_EQ); 
        
               if (r1 == NULL) 
        
                   return NULL; 
        
               r2 = PyObject_IsTrue(r1); 
        
               Py_DECREF(r1); 
        
               if (r2 < 0) 
        
                   return NULL; 
        
               return PyBool_FromLong(!r2); 
        
           case Py_LE:

FYI, the same thing is applied for PyList_GET_SIZE, too.

cpython/Include/cpython/listobject.h

Lines 30 to 37 in 94444ea

    
           static inline Py_ssize_t PyList_GET_SIZE(PyObject *op) { 
        
               PyListObject *list = _PyList_CAST(op); 
        
           #ifdef Py_GIL_DISABLED 
        
               return _Py_atomic_load_ssize_relaxed(&(_PyVarObject_CAST(list)->ob_size)); 
        
           #else 
        
               return Py_SIZE(list); 
        
           #endif 
        
           }

pythongh-112069: Make PySet_GET_SIZE to be atomic operation

a4fb0bd

corona10 added skip news topic-free-threading labels Apr 18, 2024

corona10 requested a review from colesbury April 18, 2024 15:46

corona10 requested a review from rhettinger as a code owner April 18, 2024 15:46

bedevere-app Bot mentioned this pull request Apr 18, 2024

Make set thread-safe in --disable-gil builds #112069

Closed

3 tasks

bedevere-app Bot added the awaiting core review label Apr 18, 2024

corona10 changed the title ~~gh-112069: Make PySet_GET_SIZE to be atomic operation~~ gh-112069: Make PySet_GET_SIZE to be atomic safe. Apr 18, 2024

colesbury approved these changes Apr 18, 2024

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 18, 2024

corona10 merged commit 710c01b into python:main Apr 18, 2024

bedevere-app Bot removed the awaiting merge label Apr 18, 2024

corona10 deleted the gh-112069-richcompare branch April 18, 2024 21:40

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Uh oh!

Uh oh!

gh-112069: Make PySet_GET_SIZE to be atomic safe. - #118053

gh-112069: Make PySet_GET_SIZE to be atomic safe.#118053
corona10 merged 1 commit into
python:mainfrom
corona10:gh-112069-richcompare

corona10 commented Apr 18, 2024 •

edited by bedevere-app Bot

Loading

Uh oh!

corona10 commented Apr 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

corona10 commented Apr 18, 2024 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

corona10 commented Apr 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

corona10 commented Apr 18, 2024 •

edited by bedevere-app Bot

Loading