gh-117755: Skip test_io.test_constructor() on s390x by vstinner · Pull Request #117801 · python/cpython · GitHub
Skip to content

gh-117755: Skip test_io.test_constructor() on s390x - #117801

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:test_io_s390X
Apr 15, 2024
Merged

gh-117755: Skip test_io.test_constructor() on s390x#117801
vstinner merged 1 commit into
python:mainfrom
vstinner:test_io_s390X

Conversation

@vstinner

@vstinner vstinner commented Apr 12, 2024

Copy link
Copy Markdown
Member

The test allocates 9 223 372 036 854 775 807 bytes (0x7fffffffffffffff) and mimalloc fails with a division by zero on s390x.

The test allocates 9 223 372 036 854 775 807 bytes
(0x7fffffffffffffff) and mimalloc fails with a division by zero on
s390x.
@vstinner

Copy link
Copy Markdown
Member Author

@hroncok

hroncok commented Apr 12, 2024

Copy link
Copy Markdown
Contributor

...to unblock my colleague @befeleme with Python 3.13 alpha6.

For clarification, we (me and @befeleme) are not blocked on this. The freethreding build in Fedora is disabled on s390x and we can keep it that way for now.

@vstinner

Copy link
Copy Markdown
Member Author

For clarification, we (me and @befeleme) are not blocked on this. The freethreding build in Fedora is disabled on s390x and we can keep it that way for now.

As the s390x maintainer in Python, I would prefer that you test it to discover real bugs like these ones :-)

@vstinner

Copy link
Copy Markdown
Member Author

This change is a workaround.

I wrote a fix for the root issue in mimalloc: PR gh-117809.

@vstinner
vstinner merged commit a9107fe into python:main Apr 15, 2024
@vstinner
vstinner deleted the test_io_s390X branch April 15, 2024 08:24
@bedevere-bot

Copy link
Copy Markdown

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
)

The test allocates 9 223 372 036 854 775 807 bytes
(0x7fffffffffffffff) and mimalloc fails with a division by zero on
s390x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants