gh-117655: Fix `test_strptime` raises a DeprecationWarning by nineteendo · Pull Request #117668 · python/cpython · GitHub
Skip to content

gh-117655: Fix test_strptime raises a DeprecationWarning - #117668

Merged
gpshead merged 5 commits into
python:mainfrom
nineteendo:fix-test.test_strptime
May 11, 2024
Merged

gh-117655: Fix test_strptime raises a DeprecationWarning#117668
gpshead merged 5 commits into
python:mainfrom
nineteendo:fix-test.test_strptime

Conversation

@nineteendo

@nineteendo nineteendo commented Apr 9, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Apr 9, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Apr 9, 2024
Closed
@nineteendo
nineteendo marked this pull request as ready for review April 9, 2024 08:07
@nineteendo
nineteendo marked this pull request as draft April 9, 2024 09:55
@nineteendo
nineteendo marked this pull request as ready for review April 9, 2024 12:03
@nineteendo

This comment was marked as outdated.

Sign in to view
@erlend-aasland

erlend-aasland commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

@erlend-aasland
erlend-aasland requested a review from gpshead April 18, 2024 12:40
@erlend-aasland

erlend-aasland commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

Please give Greg (and Paul) reasonable time to review before eventually pinging them. Quoting the devguide:

Getting your pull request reviewed requires a reviewer to have the spare time and motivation to look at your pull request (we cannot force anyone to review pull requests and no one is employed to look at pull requests). If your pull request has not received any notice from reviewers (i.e., no comment made) after one month, first “ping” the issue on the issue tracker to remind the subscribers that the pull request needs a review. If you don’t get a response within a week after pinging the issue, you can post on the Core Development Discourse category to ask for someone to review your pull request.

@nineteendo

nineteendo commented Apr 18, 2024

Copy link
Copy Markdown
Contributor Author

OK.

Eclips4
Eclips4 approved these changes May 11, 2024
View reviewed changes
Comment thread Lib/test/datetimetester.py Outdated
@nineteendo

nineteendo commented May 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks. I'll ask on Discourse for someone else to review this as well.

@nineteendo

nineteendo commented May 11, 2024

Copy link
Copy Markdown
Contributor Author

Thanks, I didn't dare pinging you after the comment of Erlend.

@gpshead
gpshead merged commit abead54 into python:main May 11, 2024
@nineteendo
nineteendo deleted the fix-test.test_strptime branch May 11, 2024 21:46
@gpshead

gpshead commented May 11, 2024

Copy link
Copy Markdown
Member

no problem, i'm always overflowing with notifications so I easily miss things or have other priorities at times. thanks for the cleanup! I probably should've done this type of thing when making the original change. thanks for the pings!

@gpshead gpshead added the needs backport to 3.13 bugs and security fixes label May 11, 2024
@miss-islington-app

miss-islington-app Bot commented May 11, 2024

Copy link
Copy Markdown

Thanks @nineteendo for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 11, 2024
@nineteendo @miss-islington
pythongh-117655: Prevent test_strptime from raising a DeprecationWa…
3171f63 
…rning (pythonGH-117668)

* Fix `test_strptime` raises a DeprecationWarning
* Ignore deprecation warnings where appropriate.
* Update Lib/test/datetimetester.py

This is follow on work to silence unnecessary warnings from the test suite that changes for python#70647 added.
(cherry picked from commit abead54)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@bedevere-app

bedevere-app Bot commented May 11, 2024

Copy link
Copy Markdown

GH-118956 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 11, 2024
gpshead pushed a commit that referenced this pull request May 11, 2024
@miss-islington @nineteendo
[3.13] gh-117655: Prevent test_strptime from raising a DeprecationW…
d309474 
…arning (GH-117668) (GH-118956)

gh-117655: Prevent `test_strptime` from raising a DeprecationWarning (GH-117668)

* Fix `test_strptime` raises a DeprecationWarning
* Ignore deprecation warnings where appropriate.
* Update Lib/test/datetimetester.py

This is follow on work to silence unnecessary warnings from the test suite that changes for #70647 added.
(cherry picked from commit abead54)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@bedevere-bot

bedevere-bot commented May 12, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu NoGIL 3.13 has failed when building commit d309474.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1422/builds/11) and take a look at the build logs.
  4. Check if the failure is related to this commit (d309474) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1422/builds/11

Failed tests:

  • worker>
  • <regrtest
  • test_math

Failed subtests:

  • test_map_timeout - test.test_concurrent_futures.test_process_pool.ProcessPoolSpawnProcessPoolExecutorTest.test_map_timeout

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/libregrtest/single.py", line 178, in _runtest_env_changed_exc
    _load_run_test(result, runtests)
    ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/libregrtest/single.py", line 125, in _load_run_test
    test_mod = importlib.import_module(module_name)
  File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1324, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'test.<regrtest worker>'


Traceback (test.test_zipimport.CompressedZipImportTestCase.testTraceback) ... ok


Traceback (test.test_zipimport.UncompressedZipImportTestCase.testTraceback) ... ok


Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/test_concurrent_futures/executor.py", line 71, in test_map_timeout
    self.assertEqual([None, None], results)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Lists differ: [None, None] != []


Traceback (most recent call last):
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/support/__init__.py", line 199, in _force_run
Warning --     return func(*args)
Warning -- OSError: [Errno 39] Directory not empty: '/tmp/test_python_7s3a3wxc/tmpx3992ijw/python-installation/lib/python3.13'
Warning -- 
Warning -- During handling of the above exception, another exception occurred:
Warning -- 
Warning -- Traceback (most recent call last):
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/libregrtest/run_workers.py", line 393, in run
Warning --     mp_result = self._runtest(test_name)
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/libregrtest/run_workers.py", line 353, in _runtest
Warning --     retcode, tmp_files = self.run_tmp_files(worker_runtests,
Warning --                          ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
Warning --                                             stdout_file.fileno())
Warning --                                             ^^^^^^^^^^^^^^^^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/libregrtest/run_workers.py", line 293, in run_tmp_files
Warning --     os_helper.rmtree(tmp_dir)
Warning --     ~~~~~~~~~~~~~~~~^^^^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/support/os_helper.py", line 465, in rmtree
Warning --     _rmtree(path)
Warning --     ~~~~~~~^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/support/os_helper.py", line 449, in _rmtree
Warning --     _rmtree_inner(path)
Warning --     ~~~~~~~~~~~~~^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/support/os_helper.py", line 445, in _rmtree_inner
Warning --     _rmtree_inner(fullname)
Warning --     ~~~~~~~~~~~~~^^^^^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/support/os_helper.py", line 445, in _rmtree_inner
Warning --     _rmtree_inner(fullname)
Warning --     ~~~~~~~~~~~~~^^^^^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/support/os_helper.py", line 445, in _rmtree_inner
Warning --     _rmtree_inner(fullname)
Warning --     ~~~~~~~~~~~~~^^^^^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/support/os_helper.py", line 446, in _rmtree_inner
Warning --     _force_run(path, os.rmdir, fullname)
Warning --     ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/support/__init__.py", line 210, in _force_run
Warning --     return func(*args)
Warning -- OSError: [Errno 39] Directory not empty: '/tmp/test_python_7s3a3wxc/tmpx3992ijw/python-installation/lib/python3.13'
Kill <WorkerThread #1 running test=test_source_encoding pid=231378 time=4 min 41 sec> process group
Kill <WorkerThread #3 running test=test_pep646_syntax pid=234011 time=1.1 sec> process group
Kill <WorkerThread #4 running test=test_regrtest pid=232605 time=2 min 11 sec> process group
Kill <WorkerThread #5 running test=test_cppext pid=226868 time=9 min 48 sec> process group
Kill <WorkerThread #6 running test=test_hashlib pid=233306 time=1 min 7 sec> process group
Kill <WorkerThread #7 running test=test.test_asyncio.test_queues pid=233907 time=4.1 sec> process group
Kill <WorkerThread #8 running test=test.test_multiprocessing_spawn.test_misc pid=230565 time=4 min 50 sec> process group
Kill <WorkerThread #9 running test=test.test_gdb.test_pretty_print pid=229100 time=8 min 27 sec> process group
Kill <WorkerThread #10 running test=test_pyclbr pid=233591 time=36.5 sec> process group

@bedevere-bot

bedevere-bot commented May 12, 2024

Copy link
Copy Markdown

@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@nineteendo @estyxx
pythongh-117655: Prevent test_strptime from raising a DeprecationWa…
1591569 
…rning (pythonGH-117668)

* Fix `test_strptime` raises a DeprecationWarning
* Ignore deprecation warnings where appropriate.
* Update Lib/test/datetimetester.py

This is follow on work to silence unnecessary warnings from the test suite that changes for python#70647 added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@Eclips4 Eclips4 Eclips4 approved these changes
@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nineteendo @erlend-aasland @gpshead @bedevere-bot @Eclips4