{{ message }}
gh-113317: Argument Clinic: Add libclinic.clanguage - #117455
Merged
Merged
Conversation
vstinner
force-pushed
the
ac_clang
branch
2 times, most recently
from
April 2, 2024 12:33
21917ec to
04d91d6
Compare
Member
Author
erlend-aasland
approved these changes
Apr 3, 2024
erlend-aasland
left a comment
erlend-aasland
left a comment
Contributor
There was a problem hiding this comment.
Thanks! I think libclinic.codegen makes sense. Also, it makes sense to put the option group stuff together with the parameter stuff (currently in function.py).
I realise that we already got a libclinic.language.py file with the PythonLanguage and Language classes. I'm fine with using clanguage.py instead of lang_c.py, as was your original suggestion. Up to you.
Add libclinic.clanguage module and move the following classes and functions there: * CLanguage * declare_parser() Add libclinic.codegen and move the following classes there: * BlockPrinter * BufferSeries * Destination Move the following functions to libclinic.function: * permute_left_option_groups() * permute_optional_groups() * permute_right_option_groups()
Member
Author
vstinner
enabled auto-merge (squash)
April 3, 2024 17:47
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
) Add libclinic.clanguage module and move the following classes and functions there: * CLanguage * declare_parser() Add libclinic.codegen and move the following classes there: * BlockPrinter * BufferSeries * Destination Move the following functions to libclinic.function: * permute_left_option_groups() * permute_optional_groups() * permute_right_option_groups()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add libclinic.lang_c module and move the following classes and functions there:
Add libclinic.codegen and move the following classes there:
Move these functions to libclinic.function: