{{ message }}
GH-116380: Add tests for glob.glob0() and glob.glob1(). - #117305
Closed
barneygale wants to merge 1 commit into
Closed
barneygale wants to merge 1 commit into
barneygale wants to merge 1 commit into
Conversation
These undocumented functions expand a single literal or (non-recursive) wildcard segment.
Member
Contributor
Author
|
Indeed. But they're used by third-party code, and neither deprecated nor underscore-prefixed. |
Member
|
They are not underscored because this is not needed. Opened #117337. |
Contributor
Author
|
Does deprecating these functions preclude the addition of tests in your view? |
Member
|
The new tests LGTM. Some tests will be needed for deprecation anyway. But all tests added in this PR will be changed, and maybe moved to other place. This will only increase the size of the logs. Would you mind creating a PR to deprecate these functions, along with adding new tests? Or do you prefer merging this PR first? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These undocumented functions expand a single literal or (non-recursive) wildcard segment.
glob.glob()by reducing number of system calls made #116380