{{ message }}
bpo-5028: fix doc bug for tokenize - #11683
Merged
Merged
Conversation
eamanu
approved these changes
Jan 28, 2019
Contributor
Author
|
I signed the CLA on Saturday
…On Mon, Jan 28, 2019, 3:13 AM Emmanuel Arias ***@***.*** wrote:
***@***.**** approved this pull request.
LGTM. Please, sign CLA.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11683 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHW-Mlytv8CXRHd_CQcbA5LVzmkQLc_gks5vHs1UgaJpZM4aUTNb>
.
|
Contributor
|
I think the "continuation lines are included" bit should be dropped from the doc as well (since it's irrelevant for physical lines) |
csabella
approved these changes
May 30, 2019
Contributor
|
@andrewnc, thank you for your first contribution to CPython! 🎉 |
Contributor
@csabella oh, I was hoping this would get addressed as part of this PR -- oh well :) |
Contributor
|
@asottile, yes, I probably should have requested that change before merging, but I didn't want to drag this one out. If you can, please open another PR with that change and I'll see if we can get a quick review on it. Thanks! |
Contributor
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

https://bugs.python.org/issue5028