gh-113317: Argument Clinic: Add libclinic.function by vstinner · Pull Request #116807 · python/cpython · GitHub
Skip to content

gh-113317: Argument Clinic: Add libclinic.function - #116807

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:clinic_parameter
Mar 14, 2024
Merged

gh-113317: Argument Clinic: Add libclinic.function#116807
vstinner merged 1 commit into
python:mainfrom
vstinner:clinic_parameter

Conversation

@vstinner

@vstinner vstinner commented Mar 14, 2024 •
edited by erlend-aasland
Loading

Copy link
Copy Markdown
Member
  • Move Module, Class, and Function and Parameter classes to a new libclinic.function module.
  • Move VersionTuple and Sentinels to libclinic.utils.

@bedevere-app bedevere-app Bot mentioned this pull request Mar 14, 2024
Closed
@vstinner
pythongh-113317, AC: Add libclinic.function module
a330f0e 
Move Module, Class, Function and Parameter classes to a new
libclinic.function module.

Move VersionTuple and Sentinels to libclinic.utils.
@vstinner
vstinner enabled auto-merge (squash) March 14, 2024 14:02
@vstinner
vstinner merged commit b1236a4 into python:main Mar 14, 2024
@vstinner
vstinner deleted the clinic_parameter branch March 14, 2024 14:37
@erlend-aasland erlend-aasland changed the title gh-113317, AC: Add libclinic.parameter gh-113317: Argument Clinic: Add libclinic.function Mar 19, 2024
@erlend-aasland

erlend-aasland commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

@vstinner

vstinner commented Mar 19, 2024

Copy link
Copy Markdown
Member Author

This naming does not make sense to me. Why would class, module and parameter live in a file called function.py?

Do you want to propose a different name? Or have one class per file?

@erlend-aasland

erlend-aasland commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

Do you want to propose a different name? Or have one class per file?

With one class per file you at least don't need to git grep in order to find out where things live; if the file is named after the class, it would be obvious where it was defined. Perhaps that is too granular, though.

@erlend-aasland

erlend-aasland commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

The commit message says:

Move Module, Class, Function and Parameter classes to a new libclinic.function module.

But this is not true; Parameter was not moved; it was left out of the PR.

@vstinner

vstinner commented Mar 19, 2024

Copy link
Copy Markdown
Member Author

But this is not true; Parameter was not moved; it was left out of the PR.

Parameter was moved to libclinic.function in the merged commit, no? Search for class Parameter: in b1236a4. Well, I can be wrong.

@erlend-aasland

erlend-aasland commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

vstinner added a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@vstinner
pythongh-113317, AC: Add libclinic.function (python#116807)
9c3fc84 
Move Module, Class, Function and Parameter classes to a new
libclinic.function module.

Move VersionTuple and Sentinels to libclinic.utils.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@vstinner @adorilson
pythongh-113317, AC: Add libclinic.function (python#116807)
b08aab3 
Move Module, Class, Function and Parameter classes to a new
libclinic.function module.

Move VersionTuple and Sentinels to libclinic.utils.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@vstinner @diegorusso
pythongh-113317, AC: Add libclinic.function (python#116807)
564fb56 
Move Module, Class, Function and Parameter classes to a new
libclinic.function module.

Move VersionTuple and Sentinels to libclinic.utils.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @erlend-aasland